Skip to content

Extract cloud object persistence logic to other crates.#11179

Draft
vorporeal wants to merge 2 commits into
david/extract-cloud-object-clientfrom
david/extract-cloud-object-persistence
Draft

Extract cloud object persistence logic to other crates.#11179
vorporeal wants to merge 2 commits into
david/extract-cloud-object-clientfrom
david/extract-cloud-object-persistence

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 18, 2026

Description

Pulls cloud-object SQLite persistence out of the warp app crate so Diesel-heavy persistence code can live in smaller, purpose-specific crates while preserving a path toward future model verticalization.

  • Adds cloud_object_persistence for shared cloud-object persistence infrastructure, including metadata/permissions helpers, refresh scheduling, guest/link-sharing encoding, callback-based upsert/delete primitives, and generic string object table access.
  • Moves notebook, workflow, folder, and generic-string model persistence adapters under their corresponding cloud_object_models modules so model-specific persistence can move with those models later.
  • Removes warp_server_client::persistence as a compatibility home and updates imports to use cloud_object_persistence directly.
  • Keeps app/src/persistence/sqlite.rs focused on app persistence orchestration and app-local object action conversion.
  • Adds crate-level docs for the cloud-object crates to document their intended scopes and dependency boundaries.

Testing

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_persistence
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models --tests
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
  • cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_persistence
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_objects -p cloud_object_models -p cloud_object_persistence
  • cargo check -p warp

Not manually tested; this is an internal persistence refactor with no expected user-visible behavior changes.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant