Skip to content

Move GenericStringModel to warp_server_client.#11117

Draft
vorporeal wants to merge 1 commit into
david/move-GenericCloudObject-to-warp_server_clientfrom
david/move-GenericStringModel-to-warp_server_client
Draft

Move GenericStringModel to warp_server_client.#11117
vorporeal wants to merge 1 commit into
david/move-GenericCloudObject-to-warp_server_clientfrom
david/move-GenericStringModel-to-warp_server_client

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 16, 2026

Description

Moves the portable generic-string scaffolding into warp_server_client as the next conservative step in the cloud-object extraction stack. Now that GenericCloudObject lives upstream, GenericStringModel, Serializer, and their portable helpers can move with it without pulling concrete model behavior out of the app crate.

This intentionally keeps the app-local pieces in warp: StringModel, CloudStringObject, CloudModelType, ModelEvent, QueueItem, ObjectClient dispatch, Drive rendering, and concrete model types. The only additional upstream hook is serializer-provided object-format metadata, which lets warp_server_client own the generic ServerObjectModel implementation without depending on app traits.

Testing

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
  • git -C /Users/david/src/warp --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label May 16, 2026
Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant