Skip to content

Move GenericServerObject to warp_server_client.#11114

Draft
vorporeal wants to merge 3 commits into
david/move-some-types-to-warp_server_client-cratefrom
david/move-GenericServerObject-to-warp_server_client
Draft

Move GenericServerObject to warp_server_client.#11114
vorporeal wants to merge 3 commits into
david/move-some-types-to-warp_server_client-cratefrom
david/move-GenericServerObject-to-warp_server_client

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 16, 2026

Description

Moves GenericServerObject into warp_server_client so the server-response representation can be reused outside the app crate.

This is the next extraction layer after the low-level type move: server-backed object containers are now portable, while app-specific model behavior remains implemented in warp. The new upstream server_object module owns the generic server container and supporting traits/status types, and app code adapts by implementing the minimal upstream model trait where needed.

This reduces the amount of app-only infrastructure that future server-client code has to depend on before GenericCloudObject can move upstream.

Testing

Validated on the stack tip after Phase 3:

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp_server_client
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p warp --tests
  • git --no-pager diff --check

Co-Authored-By: Oz oz-agent@warp.dev

@cla-bot cla-bot Bot added the cla-signed label May 16, 2026
Copy link
Copy Markdown
Contributor Author

vorporeal commented May 16, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant