Skip to content

Extract CloudObject client and models to separate crates.#11166

Draft
vorporeal wants to merge 3 commits into
david/create-cloud-objects-cratefrom
david/extract-cloud-object-client
Draft

Extract CloudObject client and models to separate crates.#11166
vorporeal wants to merge 3 commits into
david/create-cloud-objects-cratefrom
david/extract-cloud-object-client

Conversation

@vorporeal
Copy link
Copy Markdown
Contributor

@vorporeal vorporeal commented May 18, 2026

Description

Extracts the concrete cloud object model layer and object client interface into dedicated crates so future cloud sync work can depend on them without depending on the full app crate.

This PR adds cloud_object_models for concrete server/model types and cloud_object_client for ObjectClient, object update messages, initial load responses, permissions/action result types, and related client-facing surfaces. The app and warp_server_client retain compatibility shims/re-exports while call sites are updated to use the extracted crates where appropriate.

The PR also moves model-only tests into cloud_object_models and restores docs/comments that were accidentally dropped during the migration.

Linked Issue

None.

Testing

  • cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --all
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p cloud_object_client
  • cargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p warp --tests
  • cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models
  • HOME=$(mktemp -d) cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p warp

No manual app testing; this is a crate-boundary refactor with no intended product behavior changes.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

CHANGELOG-NONE

Co-Authored-By: Oz oz-agent@warp.dev

Copy link
Copy Markdown
Contributor Author

vorporeal commented May 18, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant