Extract CloudObject client and models to separate crates.#11166
Draft
vorporeal wants to merge 3 commits into
Draft
Extract CloudObject client and models to separate crates.#11166vorporeal wants to merge 3 commits into
CloudObject client and models to separate crates.#11166vorporeal wants to merge 3 commits into
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
This was referenced May 18, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Extracts the concrete cloud object model layer and object client interface into dedicated crates so future cloud sync work can depend on them without depending on the full app crate.
This PR adds
cloud_object_modelsfor concrete server/model types andcloud_object_clientforObjectClient, object update messages, initial load responses, permissions/action result types, and related client-facing surfaces. The app andwarp_server_clientretain compatibility shims/re-exports while call sites are updated to use the extracted crates where appropriate.The PR also moves model-only tests into
cloud_object_modelsand restores docs/comments that were accidentally dropped during the migration.Linked Issue
None.
Testing
cargo fmt --manifest-path /Users/david/src/warp/Cargo.toml --allcargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p cloud_object_clientcargo check --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_models -p warp --testscargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p cloud_object_modelsHOME=$(mktemp -d) cargo nextest run --manifest-path /Users/david/src/warp/Cargo.toml -p warpNo manual app testing; this is a crate-boundary refactor with no intended product behavior changes.
Agent Mode
CHANGELOG-NONE
Co-Authored-By: Oz oz-agent@warp.dev