ros2log new package introduction by fujitatomoya · Pull Request #1217 · ros2/ros2cli

fujitatomoya · 2026-03-29T04:53:50Z

Description

part of #1148 for Node Granurality

Fixes # (issue)

Is this user-facing behavior change?

Yes, new package is introduced ros2log

Did you use Generative AI?

Yes we did during the development. Claude Sonnet 4.6.

Additional Information

fujitatomoya · 2026-03-29T04:54:15Z

CC: @decwest

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> clean up the package and implementation. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> fix ros2log test_watch.py. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> support QoS configuration argument for ros2 log watch. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> Call content filtering API for logger name and level if available. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> add test_cli.py to test "ros2 log watch". Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> remove ros2log/README.md. Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> :construction: add list subcommand Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> bug: fix test Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> :recycle: delete non-necessary fixture node for test Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> :bug: fix to print one by one Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> support "ros2 log levels". Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com> :zap: add get and set subcommand Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> :bug: align logger's initial state during test Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> FIX: add sleep to reduce cpu consumption Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> FIX: rewrite waiting acync process Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> :FIX: delete --include-hidden-nodes option Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> FIX: import from api Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> FIX: add ValueError when empty string is inputted in get_absolute_node_name Signed-off-by: Decwest <fumiyaonishi1016@gmail.com> Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>

fujitatomoya

@Barry-Xu-2018

this is major enhancement for ros2log command that has been developed by ROS Japan Dev team. can you take a 1st look and review this?

fujitatomoya · 2026-03-29T05:05:57Z

@decwest i will start the CI for ros2log. this is gonna be the 1st time for other platforms like RHEL and window, i would expect that there are going to be several fixes to pass.

fujitatomoya · 2026-03-29T05:08:34Z

Pulls: #1217
Gist: https://gist.githubusercontent.com/fujitatomoya/56b5badffe7e633cceecafd22bf7230f/raw/2aa772334eb4fd9e80c78070cc7708c9e3e908dd/ros2.repos
BUILD args: --packages-up-to ros2log
TEST args: --packages-select ros2log
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18692

Linux
Linux-aarch64
Linux-rhel
Windows

fujitatomoya · 2026-03-29T05:38:17Z

Pulls: #1217
Gist: https://gist.githubusercontent.com/fujitatomoya/d4d623a2ac8a7ba8a901274ee598172e/raw/6e539e43c41889088e02ba07135dd567298f1f70/ros2.repos
BUILD args: --packages-up-to ros2log
TEST args: --packages-select ros2log
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18694

Linux
Linux-aarch64
Linux-rhel
Windows

fujitatomoya · 2026-03-29T05:39:28Z

Pulls: #1217
Gist: https://gist.githubusercontent.com/fujitatomoya/8c77c69338fdae4ee6dae5eb8a61f8e1/raw/6e539e43c41889088e02ba07135dd567298f1f70/ros2.repos
BUILD args: --packages-up-to ros2log
TEST args: --packages-select ros2log
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18695

Linux
Linux-aarch64
Linux-rhel
Windows

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

decwest · 2026-03-30T14:29:12Z

@fujitatomoya
Regarding the CI build failure, the following report suggests that the cause is ModuleNotFoundError: No module named 'ros2node'.
https://ci.ros2.org/job/ci_linux/28369/testReport/%28root%29/ros2log/___/

To address this, I added ros2node as an exec_depend in the following commit.
2254ca5

Also, since test_cli.py imports launch-related modules, I added the corresponding test_depend entries as well.

fujitatomoya · 2026-03-30T23:53:16Z

Pulls: #1217
Gist: https://gist.githubusercontent.com/fujitatomoya/13bac608e7f568daece4dc4e371e52b5/raw/6e539e43c41889088e02ba07135dd567298f1f70/ros2.repos
BUILD args: --packages-up-to ros2log
TEST args: --packages-select ros2log
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/18736

Linux
Linux-aarch64
Linux-rhel
Windows

Barry-Xu-2018

LGTM

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

decwest · 2026-03-31T16:13:46Z

I addressed the following build error by this commit: d5bdf97

https://ci.ros2.org/job/ci_linux-rhel/8273/testReport/(root)/ros2log/___/

fujitatomoya · 2026-04-01T12:58:24Z

Linux
Linux-aarch64
Linux-rhel
Windows

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>

fujitatomoya · 2026-04-13T11:54:12Z

@decwest as you may know, everyone is busy with Lyrical Luth release (feature freeze, branching and so on), so it will be hard to get this in the mainline source code right at this moment. we could probably come back on this to get more review before merge after lyrical luth release.

in the mean time, i will start the CI for ros2log package. we can expect that there should be (will be) no conflicts since this is new whole package to the mainline.

fujitatomoya · 2026-04-13T11:55:11Z

Linux
Linux-aarch64
Linux-rhel
Windows

fujitatomoya force-pushed the ros2log-rolling branch 2 times, most recently from 9fed13e to 0122cc2 Compare March 29, 2026 05:02

fujitatomoya force-pushed the ros2log-rolling branch from 0122cc2 to 8f3a19c Compare March 29, 2026 05:02

fujitatomoya requested review from Barry-Xu-2018 and ahcorde March 29, 2026 05:03

fujitatomoya self-assigned this Mar 29, 2026

fujitatomoya commented Mar 29, 2026

View reviewed changes

fujitatomoya mentioned this pull request Mar 29, 2026

ros2log new 1st class command group support #1148

Open

7 tasks

Barry-Xu-2018 reviewed Mar 30, 2026

View reviewed changes

Comment thread ros2log/ros2log/verb/__init__.py Outdated

Comment thread ros2log/ros2log/api/__init__.py

Comment thread ros2log/ros2log/api/__init__.py Outdated

Comment thread ros2log/package.xml Outdated

decwest added 4 commits March 30, 2026 22:41

fix copyright year

0ee0e4d

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

fix to destroy clients

934503e

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

fix to remove dependencies

10cdadb

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

add missing dependencies

2254ca5

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

Barry-Xu-2018 approved these changes Mar 31, 2026

View reviewed changes

fix type annotation

d5bdf97

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

ahcorde requested changes Apr 1, 2026

View reviewed changes

decwest and others added 4 commits April 3, 2026 20:53

add type hints to node

d4df5d0

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

Update ros2log/ros2log/verb/watch.py

81e4cb4

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>

Update ros2log/ros2log/verb/watch.py

35099fa

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>

Update ros2log/ros2log/verb/watch.py

c74d9b9

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>

decwest and others added 3 commits April 3, 2026 20:59

Update ros2log/ros2log/api/__init__.py

ce868df

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Fumiya Ohnishi <fumiyaonishi1016@gmail.com>

add checking negative timeout_sec

d55e372

Signed-off-by: Decwest <fumiyaonishi1016@gmail.com>

LogWatcher constructor should raise the exception instead of sys.exit().

89b8337

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>

fujitatomoya requested a review from ahcorde April 13, 2026 11:51

Conversation

fujitatomoya commented Mar 29, 2026

Description

Is this user-facing behavior change?

Did you use Generative AI?

Additional Information

Uh oh!

fujitatomoya commented Mar 29, 2026

Uh oh!

fujitatomoya left a comment

Choose a reason for hiding this comment

Uh oh!

fujitatomoya commented Mar 29, 2026

Uh oh!

fujitatomoya commented Mar 29, 2026

Uh oh!

fujitatomoya commented Mar 29, 2026

Uh oh!

fujitatomoya commented Mar 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

decwest commented Mar 30, 2026

Uh oh!

fujitatomoya commented Mar 30, 2026

Uh oh!

Barry-Xu-2018 left a comment

Choose a reason for hiding this comment

Uh oh!

decwest commented Mar 31, 2026

Uh oh!

fujitatomoya commented Apr 1, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fujitatomoya commented Apr 13, 2026

Uh oh!

fujitatomoya commented Apr 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants