Reduce mem usage lookups when indexing#6331
Open
PSeitz wants to merge 1 commit intoquickwit-oss:mainfrom
Open
Conversation
Sort the incoming ProcessedDocBatch by partition and group with chunk_by so get_or_create_indexed_split and the index_writer mem_usage() probes are done once per partition group instead of once per doc.
PSeitz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do
mem_usage()calls once per partition group instead of once per doc.Sort the incoming ProcessedDocBatch by partition and group with chunk_by so
get_or_create_indexed_splitand the index_writermem_usage()calls are once per partition group instead of once per doc.Context
mem_usagecalls are more expensive in moshiki, checking it per doc will be too much overhead.