Skip to content

fix: theme fixes and tiny css fixes#589

Merged
ovflowd merged 4 commits intomainfrom
fix/style-templates
Feb 5, 2026
Merged

fix: theme fixes and tiny css fixes#589
ovflowd merged 4 commits intomainfrom
fix/style-templates

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 5, 2026

This PR does tiny CSS fixes (color scheme, and whatnot)

@ovflowd ovflowd requested a review from a team as a code owner February 5, 2026 01:59
Copilot AI review requested due to automatic review settings February 5, 2026 01:59
@vercel
Copy link

vercel bot commented Feb 5, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Feb 5, 2026 10:25am

Request Review

@codecov
Copy link

codecov bot commented Feb 5, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.66%. Comparing base (f854fcc) to head (0fd1957).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   80.66%   80.66%           
=======================================
  Files         128      128           
  Lines       12392    12392           
  Branches      887      887           
=======================================
  Hits         9996     9996           
  Misses       2393     2393           
  Partials        3        3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Feb 5, 2026 •
edited
Loading

api-links Generator

apilinks.json 
Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  {
    'Agent.defaultMaxSockets': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L227',
    'Buffer.alloc': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L431',
    'Buffer.allocUnsafe': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L445',
    'Buffer.allocUnsafeSlow': 'https://github.com/nodejs/node/tree/HEAD/lib/buffer.js#L457',
...
    'agent.addRequest': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L292',
+   'agent.createConnection': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L231',
-   'agent.createConnection': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L326',
    'agent.createSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L363',
    'agent.destroy': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L595',
+   'agent.getName': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L261',
-   'agent.getName': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L484',
    'agent.keepSocketAlive': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L552',
    'agent.removeSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L491',
    'agent.reuseSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_agent.js#L588',
    'assert.assert': 'https://github.com/nodejs/node/tree/HEAD/lib/assert.js#L185',
    'asyncResource.asyncId': 'https://github.com/nodejs/node/tree/HEAD/lib/async_hooks.js#L242',
...
    'server.address': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2289',
+   'server.close': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L611',
+   'server.closeAllConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L621',
+   'server.closeIdleConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L633',
-   'server.close': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2422',
-   'server.closeAllConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L120',
-   'server.closeIdleConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L122',
    'server.getConnections': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2384',
    'server.listen': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2106',
    'server.ref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2527',
+   'server.setTimeout': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L649',
-   'server.setTimeout': 'https://github.com/nodejs/node/tree/HEAD/lib/https.js#L124',
    'server.unref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2536',
+   'server[SymbolAsyncDispose]': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L617',
+   'server[undefined]': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L656',
-   'server[SymbolAsyncDispose]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2462',
-   'server[undefined]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L2491',
    'serverresponse._finish': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L244',
    'serverresponse._implicitHeader': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L351',
    'serverresponse.assignSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L294',
    'serverresponse.detachSocket': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L305',
    'serverresponse.statusCode': 'https://github.com/nodejs/node/tree/HEAD/lib/_http_server.js#L267',
...
    'socket.addSourceSpecificMembership': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L926',
+   'socket.address': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L815',
-   'socket.address': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L714',
    'socket.bind': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L267',
    'socket.close': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L778',
+   'socket.connect': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L412',
-   'socket.connect': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L1281',
    'socket.destroySoon': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L856',
    'socket.disconnect': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L490',
    'socket.dropMembership': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L911',
    'socket.dropSourceSpecificMembership': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L944',
    'socket.end': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L795',
...
    'socket.read': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L839',
+   'socket.ref': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L1001',
-   'socket.ref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L1621',
    'socket.remoteAddress': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L827',
    'socket.resetAndDestroy': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L801',
    'socket.resume': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L830',
    'socket.send': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L615',
    'socket.sendto': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L504',
...
    'socket.setTypeOfService': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L661',
+   'socket.unref': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L1011',
-   'socket.unref': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L1635',
    'socket[SymbolAsyncDispose]': 'https://github.com/nodejs/node/tree/HEAD/lib/dgram.js#L802',
    'socket[kAfterAsyncWrite]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L990',
    'socket[kReinitializeHandle]': 'https://github.com/nodejs/node/tree/HEAD/lib/net.js#L1349',
    'string_decoder.StringDecoder': 'https://github.com/nodejs/node/tree/HEAD/lib/string_decoder.js#L60',
    'timers.clearImmediate': 'https://github.com/nodejs/node/tree/HEAD/lib/timers.js#L226',

web Generator

File Base Head Diff
styles.css 123.19 KB 124.65 KB +1.45 KB (+1.18%)
addons.html 264.87 KB 264.92 KB +43.00 B (+0.02%)
assert.html 321.04 KB 321.08 KB +43.00 B (+0.01%)
async_context.html 157.00 KB 157.04 KB +43.00 B (+0.03%)
async_hooks.html 155.27 KB 155.31 KB +43.00 B (+0.03%)
buffer.html 844.84 KB 844.88 KB +43.00 B (+0.00%)
child_process.html 360.52 KB 360.56 KB +43.00 B (+0.01%)
cli.html 491.60 KB 491.64 KB +43.00 B (+0.01%)
cluster.html 187.90 KB 187.94 KB +43.00 B (+0.02%)
console.html 138.49 KB 138.53 KB +43.00 B (+0.03%)
crypto.html 972.48 KB 972.52 KB +43.00 B (+0.00%)
debugger.html 53.55 KB 53.59 KB +43.00 B (+0.08%)
deprecations.html 499.95 KB 500.00 KB +43.00 B (+0.01%)
dgram.html 181.41 KB 181.46 KB +43.00 B (+0.02%)
diagnostics_channel.html 214.57 KB 214.61 KB +43.00 B (+0.02%)
dns.html 278.75 KB 278.79 KB +43.00 B (+0.02%)
documentation.html 37.04 KB 37.08 KB +43.00 B (+0.11%)
domain.html 101.43 KB 101.47 KB +43.00 B (+0.04%)
embedding.html 58.48 KB 58.53 KB +43.00 B (+0.07%)
environment_variables.html 43.73 KB 43.78 KB +43.00 B (+0.10%)
errors.html 449.44 KB 449.48 KB +43.00 B (+0.01%)
esm.html 153.08 KB 153.12 KB +43.00 B (+0.03%)
events.html 431.58 KB 431.62 KB +43.00 B (+0.01%)
fs.html 1.26 MB 1.26 MB +43.00 B (+0.00%)
globals.html 222.28 KB 222.32 KB +43.00 B (+0.02%)
http.html 697.92 KB 697.97 KB +43.00 B (+0.01%)
http2.html 722.45 KB 722.49 KB +43.00 B (+0.01%)
https.html 143.20 KB 143.24 KB +43.00 B (+0.03%)
index.html 35.15 KB 35.19 KB +43.00 B (+0.12%)
inspector.html 163.82 KB 163.86 KB +43.00 B (+0.03%)
intl.html 59.54 KB 59.58 KB +43.00 B (+0.07%)
module.html 308.69 KB 308.74 KB +43.00 B (+0.01%)
modules.html 176.07 KB 176.11 KB +43.00 B (+0.02%)
n-api.html 819.08 KB 819.12 KB +43.00 B (+0.01%)
net.html 345.18 KB 345.22 KB +43.00 B (+0.01%)
os.html 133.84 KB 133.88 KB +43.00 B (+0.03%)
packages.html 154.16 KB 154.20 KB +43.00 B (+0.03%)
path.html 131.82 KB 131.86 KB +43.00 B (+0.03%)
perf_hooks.html 360.69 KB 360.73 KB +43.00 B (+0.01%)
permissions.html 56.41 KB 56.45 KB +43.00 B (+0.07%)
process.html 643.50 KB 643.55 KB +43.00 B (+0.01%)
punycode.html 61.13 KB 61.17 KB +43.00 B (+0.07%)
querystring.html 60.86 KB 60.91 KB +43.00 B (+0.07%)
quic.html 345.30 KB 345.34 KB +43.00 B (+0.01%)
readline.html 237.18 KB 237.22 KB +43.00 B (+0.02%)
repl.html 177.20 KB 177.25 KB +43.00 B (+0.02%)
report.html 175.81 KB 175.85 KB +43.00 B (+0.02%)
single-executable-applications.html 105.13 KB 105.18 KB +43.00 B (+0.04%)
sqlite.html 235.58 KB 235.62 KB +43.00 B (+0.02%)
stream.html 813.69 KB 813.73 KB +43.00 B (+0.01%)
string_decoder.html 53.41 KB 53.45 KB +43.00 B (+0.08%)
synopsis.html 42.50 KB 42.55 KB +43.00 B (+0.10%)
test.html 675.90 KB 675.94 KB +43.00 B (+0.01%)
timers.html 122.62 KB 122.66 KB +43.00 B (+0.03%)
tls.html 347.43 KB 347.47 KB +43.00 B (+0.01%)
tracing.html 82.95 KB 82.99 KB +43.00 B (+0.05%)
tty.html 87.49 KB 87.54 KB +43.00 B (+0.05%)
typescript.html 53.96 KB 54.00 KB +43.00 B (+0.08%)
url.html 324.94 KB 324.98 KB +43.00 B (+0.01%)
util.html 649.08 KB 649.13 KB +43.00 B (+0.01%)
v8.html 299.54 KB 299.58 KB +43.00 B (+0.01%)
vm.html 327.35 KB 327.39 KB +43.00 B (+0.01%)
wasi.html 67.24 KB 67.29 KB +43.00 B (+0.06%)
webcrypto.html 511.23 KB 511.27 KB +43.00 B (+0.01%)
webstreams.html 331.72 KB 331.76 KB +43.00 B (+0.01%)
worker_threads.html 348.81 KB 348.86 KB +43.00 B (+0.01%)
zlib.html 273.17 KB 273.22 KB +43.00 B (+0.02%)

Copilot AI reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR implements theme-related fixes and minor CSS improvements to enhance the visual presentation of the web generator UI. The changes primarily focus on properly setting the CSS color-scheme property for better browser integration with light/dark themes, removing unnecessary overflow styling, and adjusting sidebar spacing.

Changes:

  • Added color-scheme CSS property synchronization with theme changes in both the initial template and theme hook
  • Removed overflow-x: scroll from the main element (overflow is still handled appropriately via .overflow-container)
  • Adjusted sidebar select component spacing with negative margin
  • Improved code formatting in the template HTML for better readability

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/generators/web/ui/index.css Removed unnecessary overflow-x: scroll property from main element
src/generators/web/ui/hooks/useTheme.mjs Added colorScheme style property to synchronize with theme changes
src/generators/web/ui/components/SideBar/index.module.css Added negative bottom margin to select component
src/generators/web/template.html Improved formatting and added colorScheme initialization script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

avivkeller
avivkeller reviewed Feb 5, 2026
View reviewed changes
avivkeller
avivkeller reviewed Feb 5, 2026
View reviewed changes
@ovflowd @avivkeller
Update src/generators/web/ui/hooks/useTheme.mjs
5f51d73 
Co-authored-by: Aviv Keller <me@aviv.sh>
@ovflowd @avivkeller
Update src/generators/web/template.html
0fd1957 
Co-authored-by: Aviv Keller <me@aviv.sh>
@ovflowd ovflowd added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Feb 5, 2026
@ovflowd
Copy link
Member Author

ovflowd commented Feb 5, 2026

I'm fast-tracking this as a bug fix (which doesn't require fast-track approval)

@ovflowd ovflowd merged commit f38251c into main Feb 5, 2026
20 checks passed
@ovflowd ovflowd deleted the fix/style-templates branch February 5, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@avivkeller avivkeller avivkeller approved these changes

Assignees

No one assigned

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ovflowd @avivkeller