Skip to content

fix: theme fixes and tiny css fixes #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovflowd merged 4 commits into from
Feb 5, 2026
+118 −8
Merged

fix: theme fixes and tiny css fixes #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3155f9f
fix: theme fixes and tiny css fixes
ovflowd Feb 5, 2026
072f5c0
chore: footer on search
ovflowd Feb 5, 2026
5f51d73
Update src/generators/web/ui/hooks/useTheme.mjs
ovflowd Feb 5, 2026
0fd1957
Update src/generators/web/template.html
ovflowd Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/generators/web/template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
href="https://fonts.googleapis.com/css2?family=IBM+Plex+Mono&family=Open+Sans:ital,wght@0,300..800;1,300..800" />

<!-- Apply theme before paint to avoid Flash of Unstyled Content -->
<script>document.documentElement.setAttribute("data-theme",localStorage.getItem("theme")||(matchMedia("(prefers-color-scheme: dark)").matches?"dark":"light"));</script>
<script>document.documentElement.setAttribute("data-theme", document.documentElement.style.colorScheme = localStorage.getItem("theme") || (matchMedia("(prefers-color-scheme: dark)").matches ? "dark" : "light"));</script>
<script type="importmap">{{importMap}}</script>
<script type="speculationrules">{{speculationRules}}</script>
</head>
Expand Down
44 changes: 39 additions & 5 deletions src/generators/web/ui/components/SearchBox/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,52 @@
import {
ArrowDownIcon,
ArrowTurnDownLeftIcon,
ArrowUpIcon,
} from '@heroicons/react/24/solid';
import SearchModal from '@node-core/ui-components/Common/Search/Modal';
import SearchResults from '@node-core/ui-components/Common/Search/Results';
import SearchHit from '@node-core/ui-components/Common/Search/Results/Hit';

import styles from './index.module.css';
import useOrama from '../../hooks/useOrama.mjs';

const SearchBox = () => {
const client = useOrama();

return (
<SearchModal client={client} placeholder={'Start typing...'}>
<SearchResults
noResultsTitle={'No results found for'}
onHit={hit => <SearchHit document={hit.document} />}
/>
<SearchModal client={client} placeholder="Start typing...">
<div className={styles.searchResultsContainer}>
<SearchResults
noResultsTitle="No results found for"
onHit={hit => <SearchHit document={hit.document} />}
/>
</div>

<div className={styles.footer}>
<div className={styles.shortcutWrapper}>
<div className={styles.shortcutItem}>
<kbd className={styles.shortcutKey}>
<ArrowTurnDownLeftIcon />
</kbd>
<span className={styles.shortcutLabel}>to select</span>
</div>

<div className={styles.shortcutItem}>
<kbd className={styles.shortcutKey}>
<ArrowDownIcon />
</kbd>
<kbd className={styles.shortcutKey}>
<ArrowUpIcon />
</kbd>
<span className={styles.shortcutLabel}>to navigate</span>
</div>

<div className={styles.shortcutItem}>
<kbd className={styles.shortcutKey}>esc</kbd>
<span className={styles.shortcutLabel}>to close</span>
</div>
</div>
</div>
</SearchModal>
);
};
Expand Down
76 changes: 76 additions & 0 deletions src/generators/web/ui/components/SearchBox/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
.searchResultsContainer {
display: flex;
flex-grow: 1;
flex-direction: column;
overflow-y: auto;
}

.footer {
display: flex;
justify-content: center;
align-items: baseline;
padding: 1rem;
border-top: 1px solid var(--color-neutral-200);
background-color: var(--color-neutral-100);
}

:where([data-theme='dark'], [data-theme='dark'] *) .footer {
border-top-color: var(--color-neutral-900);
background-color: var(--color-neutral-950);
}

@media (min-width: 1024px) {
.footer {
justify-content: space-between;
border-radius: 0 0 0.75rem 0.75rem;
}
}

.shortcutWrapper {
display: none;
align-items: center;
gap: 0.5rem;
}

@media (min-width: 1024px) {
.shortcutWrapper {
display: flex;
}
}

.shortcutItem {
display: flex;
align-items: center;
gap: 0.5rem;
font-size: 0.75rem;
color: var(--color-neutral-800);
}

:where([data-theme='dark'], [data-theme='dark'] *) .shortcutItem {
color: var(--color-neutral-600);
}

.shortcutKey {
font-family: var(--font-ibm-plex-mono);
border-radius: 0.375rem;
background-color: var(--color-neutral-200);
padding: 0.25rem;
font-size: 0.75rem;
}

:where([data-theme='dark'], [data-theme='dark'] *) .shortcutKey {
background-color: var(--color-neutral-900);
}

.shortcutKey svg {
width: 1rem;
height: 1rem;
}

.shortcutLabel {
color: var(--color-neutral-800);
}

:where([data-theme='dark'], [data-theme='dark'] *) .shortcutLabel {
color: var(--color-neutral-600);
}
1 change: 1 addition & 0 deletions src/generators/web/ui/components/SideBar/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
.select {
width: 100%;
margin-bottom: -1rem;
}
1 change: 1 addition & 0 deletions src/generators/web/ui/hooks/useTheme.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import { useState, useEffect, useCallback } from 'react';
*/
const applyTheme = theme => {
document.documentElement.setAttribute('data-theme', theme);
document.documentElement.style.colorScheme = theme;
localStorage.setItem('theme', theme);
};

Expand Down
2 changes: 0 additions & 2 deletions src/generators/web/ui/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@
}

main {
overflow-x: scroll;

/* Code should inherit its font size */
code {
font-size: inherit;
Expand Down
Loading