Optimize dns outgoing serialization#467
Open
anti-social wants to merge 4 commits intokeepsimple1:mainfrom
Open
Optimize dns outgoing serialization#467anti-social wants to merge 4 commits intokeepsimple1:mainfrom
anti-social wants to merge 4 commits intokeepsimple1:mainfrom
Conversation
anti-social
force-pushed
the
optimize-dns-outgoing-serialization
branch
from
c50b724 to
9515df9
Compare
anti-social
force-pushed
the
optimize-dns-outgoing-serialization
branch
from
5f7a5f3 to
6f978b3
Compare
anti-social
force-pushed
the
optimize-dns-outgoing-serialization
branch
from
6f978b3 to
56659fe
Compare
anti-social
commented
Apr 28, 2026
| Self { | ||
| data: Vec::new(), | ||
| size: MSG_HEADER_LEN, // Header is mandatory. | ||
| data: vec![0; MSG_HEADER_LEN], |
Contributor
Author
There was a problem hiding this comment.
Possibly we could create a vector with capacity of 32 bytes to reduce future reallocations.
anti-social
commented
Apr 28, 2026
|
|
||
| pub fn to_bytes(&self) -> Vec<u8> { | ||
| self.data.concat() | ||
| pub fn as_bytes(&self) -> &[u8] { |
Contributor
Author
There was a problem hiding this comment.
If we need backward compatibility I will add to_bytes(&self) -> Vec<u8> method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.