Send outgoing packets for every address#462
Draft
anti-social wants to merge 1 commit intokeepsimple1:mainfrom
Draft
Send outgoing packets for every address#462anti-social wants to merge 1 commit intokeepsimple1:mainfrom
anti-social wants to merge 1 commit intokeepsimple1:mainfrom
Conversation
anti-social
force-pushed
the
multi-addr-if
branch
4 times, most recently
from
d157e97 to
555d157
Compare
Owner
|
Thanks for submitting the PR! I understand it's still in Draft, but I have a general comment: can we split this PR into smaller ones that are relatively independent (or built on-top) of each other? That will make review and merge much easier. For example, those cleanup changes can be in one PR:
|
Contributor
Author
anti-social
force-pushed
the
multi-addr-if
branch
from
5fcd11e to
392a3ac
Compare
anti-social
commented
Apr 27, 2026
| /// Resend unregister packet. | ||
| UnregisterResend(Vec<u8>, u32, bool), // (packet content, if_index, is_ipv4) | ||
| /// Resend unregister packets. | ||
| UnregisterResend(Vec<DnsOutPacket>, u32, bool), // (packets to resend, if_index, is_ipv4) |
Contributor
Author
There was a problem hiding this comment.
We changed this variant thus DnsOutPacket should implement std::fmt::Debug
anti-social
force-pushed
the
multi-addr-if
branch
from
392a3ac to
502ae57
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #459