Skip to content

Print error code alongside label in statistics output from RoT #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xorptr wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −6
Open

Print error code alongside label in statistics output from RoT #250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions examples/htool_statistics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,15 @@ int htool_statistics(const struct htool_invocation* inv) {
}

if (stat.valid_words > STATISTIC_OFFSET(payload_update_failure_reason)) {
printf("Payload update failure reason: %s\n",
PayloadUpdateErrorToString(stat.payload_update_failure_reason));
printf("Payload update failure reason: %s (%u)\n",
PayloadUpdateErrorToString(stat.payload_update_failure_reason),
stat.payload_update_failure_reason);
}

if (stat.valid_words > STATISTIC_OFFSET(firmware_update_failure_reason)) {
printf("Firmware update failure reason: %s\n",
FirmwareUpdateErrorToString(stat.firmware_update_failure_reason));
printf("Firmware update failure reason: %s (%u)\n",
FirmwareUpdateErrorToString(stat.firmware_update_failure_reason),
stat.firmware_update_failure_reason);
}

if (stat.valid_words > STATISTIC_OFFSET(failed_firmware_minor_version)) {
Expand All @@ -275,9 +277,10 @@ int htool_statistics(const struct htool_invocation* inv) {
if (stat.valid_words > STATISTIC_OFFSET(payload_update_confirmation_cookie)) {
if (stat.payload_update_confirmation_cookie_failure_reason !=
PAYLOAD_UPDATE_SUCCESS) {
printf("Payload Update Confirmation Cookie: failed with %s\n",
printf("Payload Update Confirmation Cookie: failed with %s (%u)\n",
PayloadUpdateErrorToString(
stat.payload_update_confirmation_cookie_failure_reason));
stat.payload_update_confirmation_cookie_failure_reason),
stat.payload_update_confirmation_cookie_failure_reason);
} else {
printf("Payload Update Confirmation Cookie: %" PRIu64 "\n",
stat.payload_update_confirmation_cookie);
Expand Down
Loading