Print error code alongside label in statistics output from RoT#250
Open
xorptr wants to merge 1 commit intogoogle:mainfrom
Open
Print error code alongside label in statistics output from RoT#250xorptr wants to merge 1 commit intogoogle:mainfrom
xorptr wants to merge 1 commit intogoogle:mainfrom
Conversation
Sometimes RoT can send an error code which might not have a corresponding label defined in the running htool version (like cases where RoT introduces a new error code). In such a case htool will just print "Invalid Status Code", which is not helpful for debugging. This change adds integer error codes to output in statistics so that the error scenario can be determined even if htool does not have corresponding error label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes RoT can send an error code which might not have a corresponding label defined in the running htool version (like cases where RoT introduces a new error code). In such a case htool will just print "Invalid Status Code", which is not helpful for debugging.
This change adds integer error codes to output in statistics so that the error scenario can be determined even if htool does not have corresponding error label