Skip to content

feat: add python stubs to api#64

Merged
hdd merged 6 commits intomainfrom
backlog/python-stubs
Apr 21, 2026
Merged

feat: add python stubs to api#64
hdd merged 6 commits intomainfrom
backlog/python-stubs

Conversation

@hdd
Copy link
Copy Markdown
Collaborator

@hdd hdd commented Apr 14, 2026

Resolves F-922

add stub files for typing and autompletition

@hdd hdd requested a review from a team as a code owner April 14, 2026 07:45
@hdd hdd mentioned this pull request Apr 14, 2026
5 tasks
@hdd
Copy link
Copy Markdown
Collaborator Author

hdd commented Apr 14, 2026

@octavian-ionescu happy to target with this PR #63 rather than main.
let me know.

@octavian-ionescu
Copy link
Copy Markdown
Contributor

octavian-ionescu commented Apr 15, 2026

@octavian-ionescu happy to target with this PR #63 rather than main. let me know.

I think it's ok to target main.
But we're getting formatting errors because of black v22 being incompatible with python:3, which runs 3.14 already. I've put up an additional PR: #65

Copy link
Copy Markdown
Contributor

@dennisweil dennisweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdd as discussed today, we should look into some way to automatically update the stubs and test for correctness.

@dennisweil
Copy link
Copy Markdown
Contributor

The format check is failing. We either have to exclude .pyi files from formatting, or commit a checked and formatted version of the stubs.

@hdd hdd requested a review from dennisweil April 21, 2026 12:52
dennisweil
dennisweil previously approved these changes Apr 21, 2026
Copy link
Copy Markdown
Contributor

@dennisweil dennisweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

loren added 2 commits April 21, 2026 16:11
move pyi along the modules in the right folders
update tests to target new files location
Copy link
Copy Markdown
Contributor

@dennisweil dennisweil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hdd hdd merged commit 51e8c27 into main Apr 21, 2026
29 of 32 checks passed
@hdd hdd deleted the backlog/python-stubs branch April 21, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants