Skip to content

Implementation Sskx - Table der Tafeln#2297

Merged
TruongQuangSB merged 7 commits intomainfrom
implement-sskx
Apr 8, 2026
Merged

Implementation Sskx - Table der Tafeln#2297
TruongQuangSB merged 7 commits intomainfrom
implement-sskx

Conversation

@TruongQuangSB
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

Test Results

131 tests  +131   131 ✅ +131   29s ⏱️ +29s
 31 suites + 31     0 💤 ±  0 
 31 files   + 31     0 ❌ ±  0 

Results for commit 08950ce. ± Comparison against base commit 84eb76a.

♻️ This comment has been updated with latest results.

@TruongQuangSB TruongQuangSB merged commit 6e6ada0 into main Apr 8, 2026
14 checks passed
@TruongQuangSB TruongQuangSB deleted the implement-sskx branch April 8, 2026 14:32
Comment on lines +157 to +190
fillFootnotes(row, signal);
fillIterable(row, getColumn(cols, SskxColumns.Bemerkung), signalRahmen,
rahmen -> rahmen.stream().map(r -> {
final boolean isAngestrahlt = Streams
.stream(SignalRahmenExtensions.getSignalbegriffe(r))
.anyMatch(begriffe -> EObjectExtensions
.getNullableObject(begriffe,
b -> b.getSignalSignalbegriffAllg()
.getBeleuchtet()
.getWert())
.orElse(null) == ENUMBeleuchtet.ENUM_BELEUCHTET_ANGESTRAHLT);
if (isAngestrahlt) {
return "angestrahlt"; //$NON-NLS-1$
}
final Basis_Objekt befestigungBauwerk = EObjectExtensions
.getNullableObject(r,
e -> e.getIDSignalBefestigung()
.getValue()
.getIDBefestigungBauwerk()
.getValue())
.orElse(null);
if (befestigungBauwerk != null
&& befestigungBauwerk instanceof final Technischer_Punkt tp) {
return "Befestigung an " //$NON-NLS-1$
+ tp.getTPBeschreibung().getWert();
}

if (r.getRahmenHoehe() != null
&& r.getRahmenHoehe().getWert() != null) {
return "Rahmenhöhen beachten"; //$NON-NLS-1$
}
return null;
}).filter(Objects::nonNull).toList(), MIXED_STRING_COMPARATOR,
s -> s, SIGNAL_BEGRIFFE_BEZEICHNUNG_SEPERATOR);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TruongQuangSB How is this working? From my understanding the fillFootnotes will overwrite (in a later stage) the content that write into the bemerkungs column here, won't it?

Same question for the ssks, sslr, sslz and sszw transformator. IN all these transformators we call fillFootnotes but are also filling the Bemerkung column manually.

In the Ssvu transformator it looks like we never call fillFootnotes...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mariusheine the fillfootnotes only take the notes from Bearbeitungsvermerk and the fill bemerkung are special comment for the leading object. You can see it in ppmtab.
Yeah, is ssvu should add fillFootnotes

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TruongQuangSB This looks like an accidental or debug change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants