Skip to content

Fix nil pointer dereference in WaitForDeploymentToComplete #4993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denik wants to merge 6 commits into
base: main
Choose a base branch
from
+2 −0
Open

Fix nil pointer dereference in WaitForDeploymentToComplete #4993

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9d2b27
Fix nil pointer dereference in WaitForDeploymentToComplete
denik Apr 15, 2026
ce4da0c
Wait (not skip) when deployment Status is nil in WaitForDeploymentToC…
denik Apr 15, 2026
646cec9
Update NEXT_CHANGELOG.md
denik Apr 15, 2026
2ac9ed3
Remove unit test for WaitForDeploymentToComplete
denik Apr 15, 2026
958f0d2
[Terminated process] Only wait for deployments with known InProgress …
denik Apr 15, 2026
5348705
Reverted by user via WEB UI
denik Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions bundle/appdeploy/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ func BuildDeployment(sourcePath string, config *resources.AppConfig, gitSource *
// WaitForDeploymentToComplete waits for active and pending deployments on an app to finish.
func WaitForDeploymentToComplete(ctx context.Context, w *databricks.WorkspaceClient, app *sdkapps.App) error {
if app.ActiveDeployment != nil &&
app.ActiveDeployment.Status != nil &&
app.ActiveDeployment.Status.State == sdkapps.AppDeploymentStateInProgress {
logProgress(ctx, "Waiting for the active deployment to complete...")
_, err := w.Apps.WaitGetDeploymentAppSucceeded(ctx, app.Name, app.ActiveDeployment.DeploymentId, 20*time.Minute, nil)
Expand All @@ -59,6 +60,7 @@ func WaitForDeploymentToComplete(ctx context.Context, w *databricks.WorkspaceCli
}

if app.PendingDeployment != nil &&
app.PendingDeployment.Status != nil &&
app.PendingDeployment.Status.State == sdkapps.AppDeploymentStateInProgress {
logProgress(ctx, "Waiting for the pending deployment to complete...")
_, err := w.Apps.WaitGetDeploymentAppSucceeded(ctx, app.Name, app.PendingDeployment.DeploymentId, 20*time.Minute, nil)
Expand Down
Loading