Fix nil pointer dereference in WaitForDeploymentToComplete#4993
Open
Fix nil pointer dereference in WaitForDeploymentToComplete#4993
WaitForDeploymentToComplete#4993Conversation
Add nil checks for AppDeployment.Status before accessing Status.State. The Status field is a pointer that can be nil when the API returns a deployment before its status is populated. The OnProgress callback in the same file already had this check. Task: 001.md Co-authored-by: Isaac
…omplete Change the condition from `Status != nil && State == InProgress` to `Status == nil || State == InProgress`. When the API returns a deployment with no status yet, the function now waits for it to complete instead of silently skipping it. Update the nil-Status test to use testserver.New(t) and verify that the wait API endpoint is actually called. Task: 002.md Co-authored-by: Isaac
Co-authored-by: Isaac
Task: 003.md Co-authored-by: Isaac
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
WaitForDeploymentToCompletewhen the app deploymentStatusfield is nil. Add nil checks before accessingStatus.Statefor both active and pending deployments.Why
If the API returns a deployment object before its status is populated, the CLI panics with a nil pointer dereference during
bundle deploy.