Skip to content

fix: prevent premature error on approveAsset (bounty #32) #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jjb9707 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent premature error on approveAsset (bounty #32) #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/api/assets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,16 @@ export async function getAllowance(assetLabel, spenderName) {
}

export async function approveAsset(assetLabel, spenderName) {
const contract = await getContract(assetLabel, true);
const spenderContract = await getContract(spenderName);
const spenderAddress = spenderContract.address;
try {
const contract = await getContract(assetLabel, true);
const spenderContract = await getContract(spenderName);

if (!contract || !spenderContract) {
showError('Contract not found. Please check your network connection.');
return;
}

const spenderAddress = spenderContract.address;
let tx = await contract.approve(spenderAddress, ethers.constants.MaxUint256);
let receipt = await tx.wait();
if (receipt && receipt.status == 1) {
Expand All @@ -71,6 +77,10 @@ export async function approveAsset(assetLabel, spenderName) {
return true;
}
} catch(e) {
// Suppress user-rejection errors (MetaMask throws on deny)
if (e?.code === 'ACTION_REJECTED' || e?.code === 4001) {
return;
}
showError(e);
}
}