fix: prevent premature error on approveAsset (bounty #32)#152
Open
jjb9707 wants to merge 1 commit into
Open
Conversation
…side try-catch - Move getContract() calls inside the try-catch block to prevent uncaught errors before wallet interaction (issue capofficial#32) - Add null checks for contract resolution failures - Suppress user-rejection errors (MetaMask ACTION_REJECTED / 4001) - Show friendly error when network connection is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Problem
approveAsset()insrc/api/assets.jscalledgetContract()and accessed.addressbefore the try-catch block. When contracts failed to resolve (e.g. wrong network), the error leaked before the wallet interaction, showing a premature error toast.Changes
getContract()calls inside the try-catch blockACTION_REJECTED/ code 4001)Testing
Bounty
This resolves bounty #32 ($25 paid in crypto).