ci: put clippy in strict mode

.github/workflows/ci.yml

@@ -76,7 +76,7 @@ jobs:
       run: cargo check ${CI_CARGO_ARGS}
 
     - name: "Run Clippy"
-      run: cargo clippy ${CI_CARGO_ARGS}
+      run: cargo clippy ${CI_CARGO_ARGS} -- --deny=warnings
 
   #
   # A complete but basic build of the project, running on common x86-64 ubuntu

lib/osi/src/mem.rs

@@ -165,7 +165,7 @@ pub const unsafe fn bswap_copy<T>(v: &T) -> T {
 /// Any type can be aliased as a possibly uninitialized type. This is usually
 /// only necessary when providing initialized data to code that can handle
 /// possibly uninitialized data.
-pub const fn as_uninit<'a, T>(v: &'a T) -> &'a Uninit<T> {
+pub const fn as_uninit<T>(v: &T) -> &Uninit<T> {
     unsafe {
         core::mem::transmute::<&T, &Uninit<T>>(v)
     }
@@ -174,7 +174,7 @@ pub const fn as_uninit<'a, T>(v: &'a T) -> &'a Uninit<T> {
 /// Alias a slice as a [`MaybeUninit`](core::mem::MaybeUninit).
 ///
 /// This works like [`as_uninit()`] but for slices of `T`.
-pub const fn slice_as_uninit<'a, T>(v: &'a [T]) -> &'a [Uninit<T>] {
+pub const fn slice_as_uninit<T>(v: &[T]) -> &[Uninit<T>] {
     unsafe {
         core::mem::transmute::<&[T], &[Uninit<T>]>(v)
     }
@@ -187,7 +187,7 @@ pub const fn slice_as_uninit<'a, T>(v: &'a [T]) -> &'a [Uninit<T>] {
 /// It is up to the caller to guarantee that the [`MaybeUninit<T>`] really is
 /// in an initialized state. Calling this when the content is not yet fully
 /// initialized causes immediate undefined behavior.
-pub const unsafe fn assume_init<'a, T>(v: &'a Uninit<T>) -> &'a T {
+pub const unsafe fn assume_init<T>(v: &Uninit<T>) -> &T {
     unsafe {
         core::mem::transmute::<&Uninit<T>, &T>(v)
     }
@@ -201,7 +201,7 @@ pub const unsafe fn assume_init<'a, T>(v: &'a Uninit<T>) -> &'a T {
 /// It is up to the caller to guarantee that the [`MaybeUninit<T>`] really is
 /// in an initialized state. Calling this when the content is not yet fully
 /// initialized causes immediate undefined behavior.
-pub const unsafe fn assume_init_mut<'a, T>(v: &'a mut Uninit<T>) -> &'a mut T {
+pub const unsafe fn assume_init_mut<T>(v: &mut Uninit<T>) -> &mut T {
     unsafe {
         core::mem::transmute::<&mut Uninit<T>, &mut T>(v)
     }
@@ -214,7 +214,7 @@ pub const unsafe fn assume_init_mut<'a, T>(v: &'a mut Uninit<T>) -> &'a mut T {
 /// It is up to the caller to guarantee that the [`MaybeUninit<T>`] really is
 /// in an initialized state. Calling this when the content is not yet fully
 /// initialized causes immediate undefined behavior.
-pub const unsafe fn slice_assume_init<'a, T>(v: &'a [Uninit<T>]) -> &'a [T] {
+pub const unsafe fn slice_assume_init<T>(v: &[Uninit<T>]) -> &[T] {
     unsafe {
         core::mem::transmute::<&[Uninit<T>], &[T]>(v)
     }
@@ -228,7 +228,7 @@ pub const unsafe fn slice_assume_init<'a, T>(v: &'a [Uninit<T>]) -> &'a [T] {
 /// It is up to the caller to guarantee that the [`MaybeUninit<T>`] really is
 /// in an initialized state. Calling this when the content is not yet fully
 /// initialized causes immediate undefined behavior.
-pub const unsafe fn slice_assume_init_mut<'a, T>(v: &'a mut [Uninit<T>]) -> &'a mut [T] {
+pub const unsafe fn slice_assume_init_mut<T>(v: &mut [Uninit<T>]) -> &mut [T] {
     unsafe {
         core::mem::transmute::<&mut [Uninit<T>], &mut [T]>(v)
     }

lib/osi/src/polonius.rs

@@ -71,7 +71,7 @@ mod test {
     // the function returned a value that is not dependent on the lifetime.
     #[test]
     fn coerce_loop_return() {
-        fn get<'a>(v: &'a mut (u16,)) -> Option<&'a u16> {
+        fn get(v: &mut (u16,)) -> Option<&u16> {
             if v.0 == 0 {
                 Some(&v.0)
             } else {

lib/osi/src/test.rs

@@ -126,6 +126,7 @@ impl<T: ?Sized> core::default::Default for InvariantType<T> {
     }
 }
 
+#[allow(clippy::module_inception)]
 #[cfg(test)]
 mod test {
     use super::*;