Conversation
Drop prototype lifetimes if they can be safely elided. Clippy will warn about this. Signed-off-by: David Rheinsberg <david@readahead.eu>
Drop the 'a lifetime of get(), given that it is automatically inferred. Signed-off-by: David Rheinsberg <david@readahead.eu>
Allow for "mod test" inside of "mod test", given that we use this style for all unit tests. Signed-off-by: David Rheinsberg <david@readahead.eu>
Ensure that clippy runs in strict mode, denying any warnings and ensuring that we catch those in CI. Signed-off-by: David Rheinsberg <david@readahead.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of minor fixes to ensure strict clippy can be enabled in CI.