Skip to content

Fix flaky BATS integration tests for extraction, and JMX startup #4303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janhoy wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −2
Open

Fix flaky BATS integration tests for extraction, and JMX startup #4303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion solr/packaging/test/test_extraction.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ setup_file() {
if command -v docker >/dev/null 2>&1 && docker info >/dev/null 2>&1; then
export TIKA_PORT=$((SOLR_PORT+5))
docker run --rm -p ${TIKA_PORT}:9998 --name bats_tika -d apache/tika:3.2.3.0-full >/dev/null 2>&1 || true
echo "Tika Server started on port ${TIKA_PORT}" >&3
Copy link
Copy Markdown
Contributor

@epugh epugh Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. I guess in the past it fired up fast enough most of the time that we didn't need the wait for?

echo "Waiting for Tika Server to be ready on port ${TIKA_PORT}" >&3
if ! wait_for 120 3 curl -s -f "http://localhost:${TIKA_PORT}/tika" -o /dev/null; then
export DOCKER_UNAVAILABLE=1
echo "WARNING: Tika Server did not become ready in time; Tika-dependent tests will be bypassed." >&3
else
echo "Tika Server is ready on port ${TIKA_PORT}" >&3
fi
else
export DOCKER_UNAVAILABLE=1
echo "WARNING: Docker not available (CLI missing or daemon not running); Tika-dependent tests will be bypassed." >&3
Expand Down
2 changes: 1 addition & 1 deletion solr/packaging/test/test_start_solr.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ teardown() {
solr assert --started http://localhost:${SOLR_PORT} --timeout 5000

run cat ${SOLR_LOGS_DIR}/solr-${SOLR_PORT}-console.log
refute_output --partial 'Exception'
refute_output --partial 'Exception in thread'
}

@test "deprecated system properties converted to modern properties" {
Expand Down
Loading