Fix flaky BATS integration tests for extraction, and JMX startup#4303
Open
janhoy wants to merge 1 commit intoapache:mainfrom
Open
Fix flaky BATS integration tests for extraction, and JMX startup#4303janhoy wants to merge 1 commit intoapache:mainfrom
janhoy wants to merge 1 commit intoapache:mainfrom
Conversation
- test_extraction.bats: wait for Tika Docker container to be ready before tests run; apache/tika:3.2.3.0-full takes 30+ s to start inside the container and there was no readiness check. Falls back to DOCKER_UNAVAILABLE (skip) if Tika never becomes ready within 120 s. - test_post.bats: guard Solr availability with wait_for before creating the 'monitors_verbose' collection in the verbose-echo test, preventing IOException when Solr is temporarily unresponsive after preceding tests. - test_start_solr.bats: narrow SOLR-16976 assertion from 'Exception' to 'Exception in thread' so a benign ShutdownMonitor BindException (port-reuse race from prior test teardown) no longer causes a false failure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
epugh
reviewed
Apr 21, 2026
| if command -v docker >/dev/null 2>&1 && docker info >/dev/null 2>&1; then | ||
| export TIKA_PORT=$((SOLR_PORT+5)) | ||
| docker run --rm -p ${TIKA_PORT}:9998 --name bats_tika -d apache/tika:3.2.3.0-full >/dev/null 2>&1 || true | ||
| echo "Tika Server started on port ${TIKA_PORT}" >&3 |
Contributor
There was a problem hiding this comment.
This is awesome. I guess in the past it fired up fast enough most of the time that we didn't need the wait for?
epugh
approved these changes
Apr 21, 2026
Contributor
epugh
left a comment
epugh
left a comment
There was a problem hiding this comment.
Thanks for improving things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See test history in develocity