Creilly11235/vertex shell sidebar provider migration#577
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Dependency License Review
License distribution
Excluded packages
|
5eb844d to
d161a9c
Compare
| const [isCollapsed, setIsCollapsed] = useLocalStorage<boolean>({ | ||
| key: SIDEBAR_COLLAPSED_KEY, | ||
| defaultValue: false, | ||
| }); |
There was a problem hiding this comment.
up until now the state of the sidebar (open/close) was stored in the local storage, such that on a refresh the sidebar would be in the state before the refresh. now its not anymore. we should bring this behaviour back
d161a9c to
6328f62
Compare
6328f62 to
a8db5fc
Compare
|
@petervachon let me know if we should start reviewing this PR, or if you are gonna start again as there are some drafts as follow ups |
|
This PR has been stale for over 2 weeks with no new commits. Closing — feel free to reopen if you'd like to continue this work. To keep a PR exempt from this automation, add the |
|
Hey @alincadariu — starting fresh. All the feedback from this PR has been addressed in a new clean stack:
The localStorage persistence concern you flagged is resolved — collapsed state now uses the shadcn |
Switch to using shadcn-based sidebar component. This PR swaps the hand built sidebar we currently have in the shell and adds the sub-nav capabilities. Demo docs and preview updates are in a separate pr to keep this one small. This PR is not dependent on #576 but without #576 it breaks the preview in the docs.