Skip to content

Creilly11235/vertex shell sidebar provider migration#577

Closed
creilly11235 wants to merge 1 commit into
mainfrom
creilly11235/vertex-shell-sidebar-provider-migration
Closed

Creilly11235/vertex shell sidebar provider migration#577
creilly11235 wants to merge 1 commit into
mainfrom
creilly11235/vertex-shell-sidebar-provider-migration

Conversation

@creilly11235
Copy link
Copy Markdown
Contributor

Switch to using shadcn-based sidebar component. This PR swaps the hand built sidebar we currently have in the shell and adds the sub-nav capabilities. Demo docs and preview updates are in a separate pr to keep this one small. This PR is not dependent on #576 but without #576 it breaks the preview in the docs.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Apr 24, 2026, 01:11:42 PM
apollo-docs ❌ Failed: Building: Summary: /vercel/path0/.turbo/runs/3Coos8EabTUEMyCvJVOCNVx1hqN.json Building: Failed: ... N/A, Logs Apr 24, 2026, 01:11:32 PM
apollo-landing 🟢 Ready Preview, Logs Apr 24, 2026, 01:11:44 PM
apollo-ui-react 🟢 Ready Preview, Logs Apr 24, 2026, 01:12:53 PM
apollo-vertex 🟢 Ready Preview, Logs Apr 24, 2026, 01:13:20 PM

@github-actions github-actions Bot added app:apollo-vertex size:L 100-499 changed lines. labels Apr 24, 2026
@github-actions
Copy link
Copy Markdown

Dependency License Review

  • 1941 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1701
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Comment on lines -28 to -31
const [isCollapsed, setIsCollapsed] = useLocalStorage<boolean>({
key: SIDEBAR_COLLAPSED_KEY,
defaultValue: false,
});
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

up until now the state of the sidebar (open/close) was stored in the local storage, such that on a refresh the sidebar would be in the state before the refresh. now its not anymore. we should bring this behaviour back

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alincadariu Updated!

@creilly11235 creilly11235 force-pushed the creilly11235/vertex-shell-sidebar-provider-migration branch from d161a9c to 6328f62 Compare April 24, 2026 20:02
@creilly11235 creilly11235 marked this pull request as ready for review April 24, 2026 20:03
@creilly11235 creilly11235 requested a review from a team as a code owner April 24, 2026 20:03
@creilly11235 creilly11235 requested review from KokoMilev and alincadariu and removed request for a team April 24, 2026 20:03
@KokoMilev KokoMilev enabled auto-merge (rebase) April 24, 2026 20:03
@creilly11235 creilly11235 force-pushed the creilly11235/vertex-shell-sidebar-provider-migration branch from 6328f62 to a8db5fc Compare April 24, 2026 20:10
@alincadariu
Copy link
Copy Markdown
Collaborator

@petervachon let me know if we should start reviewing this PR, or if you are gonna start again as there are some drafts as follow ups

@github-actions
Copy link
Copy Markdown

This PR has been stale for over 2 weeks with no new commits. Closing — feel free to reopen if you'd like to continue this work. To keep a PR exempt from this automation, add the do-not-close label.

@github-actions github-actions Bot closed this May 11, 2026
auto-merge was automatically disabled May 11, 2026 10:16

Pull request was closed

@petervachon
Copy link
Copy Markdown
Collaborator

Hey @alincadariu — starting fresh. All the feedback from this PR has been addressed in a new clean stack:

The localStorage persistence concern you flagged is resolved — collapsed state now uses the shadcn SidebarProvider cookie (sidebar_state), so it survives refreshes without touching localStorage at all. Closing this one out in favour of the new stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants