Skip to content

feat(apollo-vertex): docs, templates and preview fixes#540

Closed
creilly11235 wants to merge 1 commit into
mainfrom
creilly11235/vertex-docs-templates
Closed

feat(apollo-vertex): docs, templates and preview fixes#540
creilly11235 wants to merge 1 commit into
mainfrom
creilly11235/vertex-docs-templates

Conversation

@creilly11235
Copy link
Copy Markdown
Contributor

Summary

  • Add SidebarTemplate and SidebarTemplateDynamic for sidebar documentation previews
  • Update ShellRoot template with latest changes
  • Update sidebar and shell documentation pages
  • Fix z-index stacking in preview-full-screen (initial={false} for SSR hydration)

Split from #468 — docs and template changes, independent of other PRs.

Test plan

  • Sidebar docs page renders correctly at /components/sidebar
  • Shell pattern page renders correctly at /patterns/shell
  • SidebarTemplate renders in full-screen preview without z-index issues
  • No SSR hydration flash in preview components

🤖 Generated with Claude Code

@creilly11235 creilly11235 requested a review from a team as a code owner April 18, 2026 01:25
@creilly11235 creilly11235 requested review from VKravchuk and angeloaltamiranom and removed request for a team April 18, 2026 01:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (PT)
apollo-design 🟢 Ready Preview, Logs Apr 17, 2026, 06:44:42 PM
apollo-docs 🟢 Ready Preview, Logs Apr 17, 2026, 06:43:48 PM
apollo-landing 🟢 Ready Preview, Logs Apr 17, 2026, 06:43:01 PM
apollo-ui-react 🟢 Ready Preview, Logs Apr 17, 2026, 06:43:11 PM
apollo-vertex 🟢 Ready Preview, Logs Apr 17, 2026, 06:44:22 PM

@KokoMilev KokoMilev enabled auto-merge (rebase) April 18, 2026 01:25
@github-actions github-actions Bot added app:apollo-vertex size:L 100-499 changed lines. labels Apr 18, 2026
@github-actions
Copy link
Copy Markdown

Dependency License Review

  • 1941 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 3 package(s) excluded (see details below)
License distribution
License Packages
MIT 1701
ISC 89
Apache-2.0 61
BSD-3-Clause 28
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 5
MIT OR Apache-2.0 3
MIT-0 3
CC0-1.0 3
LGPL-3.0-or-later 2
(MIT OR Apache-2.0) 2
Unlicense 2
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
@img/sharp-libvips-linuxmusl-x64 1.2.4 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

@creilly11235 creilly11235 force-pushed the creilly11235/vertex-docs-templates branch from bde10db to 129cca7 Compare April 18, 2026 01:31
- Add SidebarTemplate and SidebarTemplateDynamic for sidebar docs
- Update ShellRoot template
- Update sidebar and shell documentation pages
- Fix z-index stacking in preview-full-screen (initial={false} for SSR)
- Include shell.tsx with subItems type for ShellNavItem

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@creilly11235 creilly11235 force-pushed the creilly11235/vertex-docs-templates branch from 129cca7 to b423eda Compare April 18, 2026 01:41
@creilly11235
Copy link
Copy Markdown
Contributor Author

Closing in favor of a smaller, stacked set of PRs per team guidelines:

Each replacement is one concern, under Peter's 800–1000 LoC cap, stacked via the manual-stacked-PR workflow.

auto-merge was automatically disabled April 24, 2026 03:40

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app:apollo-vertex size:L 100-499 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant