docs(skills): adopt query doctor as step 1 of audit contract#6
Merged
Conversation
The audit contract now starts with `topline query doctor` (added in PR #5) instead of an ad-hoc freshness SQL. doctor returns a deterministic JSON readiness payload (queryTokenPresent, schemaReachable, tableCount, missingTables, recommendation) without printing the token, and covers both auth and warehouse-coverage checks in one call. skills/hermes/SKILL.md bumped to 1.3.0; claude-code variant matched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5. Now that
topline query doctoris inmain, update the bundled skills so agents call it as step 1 of the pipeline audit contract instead of an ad-hoc freshness SQL probe.query doctoris deterministic, never prints the token, and surfaces auth + warehouse coverage in one JSON payload (queryTokenPresent,tokenSourceEnvVar,rawPitRejected,schemaReachable,tableCount,expectedTables,missingTables,recommendation). It replaces the prior "freshness SQL probe" as the first deterministic check before any analytics SQL — and it is the right place to detect coverage gaps (missing tables) and treat them asos-mcpbugs rather than silently falling back to REST.Changes
skills/hermes/SKILL.md→ 1.3.0topline --agent query doctorand document the JSON payload shape.query doctor, step 2 is the composite SQL (with optionaldateprepended for custom windows). Soft 5-step list compressed to 3; hard ceiling unchanged at 4 calls.recommendation/missingTables.query doctor.skills/claude-code/SKILL.md— same contract change, shorter form.Test plan
query doctoras the first CRM tool call, followed by a single composite SQL.TOPLINE_QUERY_TOKENis unset, agent stops at doctor and reports the readiness gap (no silent REST fallback).missingTablesis non-empty, the final answer surfaces the missing table(s) as anos-mcpcoverage bug.