Skip to content

docs(skills): ban python wrappers and mid-run skill edits in audit contract#7

Merged
alexskatell merged 1 commit into
mainfrom
feat/skills-no-wrappers
May 13, 2026
Merged

docs(skills): ban python wrappers and mid-run skill edits in audit contract#7
alexskatell merged 1 commit into
mainfrom
feat/skills-no-wrappers

Conversation

@alexskatell
Copy link
Copy Markdown
Contributor

Why

Latest test trace of the SQL-first audit contract blew the 4-call ceiling because:

  1. The agent wrapped topline --agent query sql calls in python3 / execute_code subprocess loops to "verify" and "reshape" the output. Same anti-pattern as REST fan-out, different surface.
  2. The agent invoked skill_manage during the audit to patch the topline-os-cli / topline-os-crm-audits skills — meaning the contract being tested wasn't the documented contract.

The two were the new dominant failure modes after this week's earlier PRs (#4, #5, #6) successfully killed REST-first fallback and adopted query doctor as step 1. Tightening the contract closes both loopholes.

What

skills/hermes/SKILL.md (1.3.0 -> 1.4.0)

skills/claude-code/SKILL.md

Mirrors the same contract in the shorter Claude Code-targeted form.

What this is not

  • No CLI code changes. Pure skills/docs.
  • Does not remove the underlying query commands, pipeline audit, or any tool. They remain available for the drilldown / diagnostic exceptions that already require the user to explicitly ask.

Follow-ups (separate PRs)

  • Phase 2 in docs/plans/2026-05-13-sql-first-retrieval-improvements.md (query template registry).
  • Phase 3 sales-native composite reports.
  • os-mcp view rollforward (contact_timeline UNION appointments/call_events, pipeline_activity_window, pipeline_snapshot, pipeline_movement_window, warehouse_freshness) — different repo.

…ntract

Tightens the SQL-first audit contract after a test trace blew the 4-call
ceiling with python3 subprocess loops around `topline` and mid-run
`skill_manage` edits. Both are now explicitly banned in the default flow.

- hermes/SKILL.md: 1.3.0 -> 1.4.0
  - Readiness probe now describes the doctor / query-help fallback for
    stale binaries (a real failure mode when PR #5 merged but the local
    binary wasn't rebuilt). Recommends `scripts/install-local.sh`.
  - Hard ceiling section lists three banned classes: REST fan-out,
    python/subprocess wrappers around topline, mid-run skill edits.
  - Two new pitfalls (10, 11) covering python wrappers and mid-run
    skill_manage usage.
- claude-code/SKILL.md: mirrors the same contract in shorter form.

No code, no behavior change to the CLI itself.
@alexskatell alexskatell merged commit 2b89248 into main May 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant