fix: Replace InitGameLogicRandom with InitRandom for consistent client and audio seeds

[Caball009]

• Follow-up PR for bugfix(skirmish): Prevent mismatch in Replay playback by restoring correct game seed after restarting a Skirmish game #2270

This PR removes function InitGameLogicRandom, and changes all use cases to InitRandom. The former only sets the logical seed values (important for the CRC), while the latter also sets the client and audio seed values. I think setting all 3 types of seed values improves consistency. This change is not user-facing.

I checked 2000+ of Joker's (short) replays and this change did not introduce any new mismatches, as expected.

TODO:

• Replicate in Generals.

[greptile-apps]

Greptile Summary

Refactors random seed initialization by removing InitGameLogicRandom and consolidating to InitRandom, which sets all three seed types (logic, client, audio) for better consistency.

Critical Issue:

• GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp still calls the removed InitGameLogicRandom function, causing a compilation error

Changes Made:

• Removed InitGameLogicRandom function declaration and implementation
• Updated 6 call sites across GeneralsMD to use InitRandom
• Cleaned up commented-out code in Recorder.cpp and MapSelectMenu.cpp

Confidence Score: 0/5

• This PR will fail to compile due to missing function updates
• The function declaration was removed from the header but one call site in GameSpyGameInfo.cpp was not updated, resulting in undefined function compilation error. While the changes that were made are correct, the incomplete refactoring makes this PR not mergeable.
• GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp (not in this PR) requires immediate update before merge

Important Files Changed

Filename	Overview
Core/GameEngine/Include/Common/RandomValue.h	Removed declaration of InitGameLogicRandom, clean header change
Core/GameEngine/Source/GameNetwork/GameSpy/StagingRoomGameInfo.cpp	Updated call from InitGameLogicRandom to InitRandom, correct implementation
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/SkirmishGameOptionsMenu.cpp	Updated both calls from InitGameLogicRandom to InitRandom, correct implementation

_{Last reviewed commit: f6aa7d2}

[greptile-apps]

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp
This file still calls InitGameLogicRandom which was removed in this PR, causing a compilation error

		InitRandom( TheGameSpyGame->getSeed() );
		DEBUG_LOG(("InitRandom( %d )", TheGameSpyGame->getSeed()));

Prompt To Fix With AI

This is a comment left during a code review.
Path: GeneralsMD/Code/GameEngine/Source/GameNetwork/GameSpyGameInfo.cpp
Line: 566-567

Comment:
This file still calls `InitGameLogicRandom` which was removed in this PR, causing a compilation error

```suggestion
		InitRandom( TheGameSpyGame->getSeed() );
		DEBUG_LOG(("InitRandom( %d )", TheGameSpyGame->getSeed()));
```

How can I resolve this? If you propose a fix, please make it concise.

[Mauller]

Broke da build! but looks like it's due to core files being altered :P

[Caball009]

Yes, Generals isn't updated yet but the core files are, so that project won't compile.

[bobtista]

Do we use this?

[Caball009]

I don't think so, though I use that macro when testing sometimes to reduce the chances for run-to-run variance.

[Mauller]

Considering the todo above, do skirmish games have a random seed? Wondering if the comment can be removed?

[Caball009]

Considering the todo above, do skirmish games have a random seed?

Skirmish multiplayer maps have a random seed, skirmish single player maps / scenarios do not.

[Mauller]

might be good to cleanup the todo aswell if it's not relevant

[Caball009]

It's not entirely clear to me if this todo is completely done, but it looks that way so I'll remove the comment.

[greptile-apps]

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}