Skip to content

Fix update scheduling seed checks #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Ye merged 2 commits into from
Apr 19, 2026
Merged

Fix update scheduling seed checks #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec97bd1
Fix updatePreferences issue
Kyle-Ye Apr 18, 2026
ccf7de6
Fix setNextUpdate issue
Kyle-Ye Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/OpenSwiftUI/Integration/Hosting/UIKit/View/UIHostingViewBase.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,8 +847,8 @@ final package class DisplayLink: NSObject {

package func setNextUpdate(delay: Double, interval: Double, reasons: Set<UInt32>) {
let newNextUpdate: Time
if delay >= 0.01 {
newNextUpdate = (currentUpdate ?? .systemUptime) + interval
if delay >= 0.001 {
newNextUpdate = (currentUpdate ?? .systemUptime) + delay
} else {
newNextUpdate = .zero
}
Expand Down
3 changes: 1 addition & 2 deletions Sources/OpenSwiftUICore/Graph/GraphHost.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,8 +562,7 @@ extension GraphHost {

package final func updatePreferences() -> Bool {
let seed = hostPreferenceValues.value?.seed ?? .empty
let lastSeed = lastHostPreferencesSeed
let didUpdate = !seed.isInvalid && !lastSeed.isInvalid && (seed.value != lastSeed.value)
let didUpdate = !seed.matches(lastHostPreferencesSeed)
lastHostPreferencesSeed = seed
return didUpdate
}
Expand Down
Loading