Skip to content

Fix update scheduling seed checks#852

Merged
Kyle-Ye merged 2 commits intomainfrom
bugfix/update
Apr 19, 2026
Merged

Fix update scheduling seed checks#852
Kyle-Ye merged 2 commits intomainfrom
bugfix/update

Conversation

@Kyle-Ye
Copy link
Copy Markdown
Collaborator

@Kyle-Ye Kyle-Ye commented Apr 18, 2026

Summary

  • Update GraphHost.updatePreferences() to use VersionSeed.matches(_:) when comparing the current host preference seed with the last recorded seed.
  • Update DisplayLink.setNextUpdate(delay:interval:reasons:) to:
    • use delay >= 0.001
    • schedule with (currentUpdate ?? .systemUptime) + delay
    • keep interval for frame interval configuration

@augmentcode
Copy link
Copy Markdown

augmentcode bot commented Apr 18, 2026

🤖 Augment PR Summary

Summary: Fixes preference update detection by using VersionSeed.matches(_:) so host preference changes (including initial/invalid seeds) are handled consistently.

Changes: Tweaks DisplayLink.setNextUpdate to schedule using (currentUpdate ?? .systemUptime) + delay (with a 1ms threshold) while keeping interval solely for frame-rate configuration.

🤖 Was this summary useful? React with 👍 or 👎

Copy link
Copy Markdown

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No suggestions at this time.

Comment augment review to trigger a new review at any time.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.19%. Comparing base (8b4076e) to head (ccf7de6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #852       +/-   ##
===========================================
+ Coverage   14.41%   27.19%   +12.78%     
===========================================
  Files         634      673       +39     
  Lines       39006    44165     +5159     
===========================================
+ Hits         5621    12012     +6391     
+ Misses      33385    32153     -1232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kyle-Ye Kyle-Ye merged commit 5d38d98 into main Apr 19, 2026
7 of 13 checks passed
@Kyle-Ye Kyle-Ye deleted the bugfix/update branch April 19, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant