security: zeroize encoding and decoding keys#483
Merged
arckoor merged 1 commit intoKeats:masterfrom Apr 18, 2026
Merged
Conversation
arckoor
requested changes
Apr 17, 2026
Collaborator
|
You probably also need to rebase onto master for CI to work |
Collaborator
|
lgtm but I'd prefer a linear history |
Addresses Keats#337 `PemEncodedKey` is still not zeroized and may contain sensistive data. Currently, it uses simple_asn1 which does not support zeroize and also does not support parsing without taking ownership of the data.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #337.
PemEncodedKeyis still not zeroized and may contain sensistive data. Currently, it usessimple_asn1which does not support zeroize and also does not support parsing without taking ownership of the data.