Open
Conversation
Contributor
Author
|
I had quite some fun while implementing this, especially recalling the TLV encoding and writing a custom recursive parser. |
`PemEncodedKey` is now zeroized and no longer contains ASN.1 parsed data. Because `Vec<simple_asn1::ASN1Block>` owns the underlying bytes and does not support zeroization, the full ASN.1 parsing has been replaced by a custom partial ASN.1 implementation. This parsing is performed only to classify the key type during construction and to extract the key bytes on access. This change also allows the removal of the `simple_asn1` dependency.
Collaborator
|
This will likely take me a while to review, my ASN.1 skills are rusty at best |
Contributor
Author
|
Let me
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PemEncodedKeyis now zeroized and no longer contains ASN.1 parseddata. Because
Vec<simple_asn1::ASN1Block>owns the underlying bytesand does not support zeroization, the full ASN.1 parsing has been
replaced by a custom partial ASN.1 implementation. This parsing is
performed only to classify the key type during construction and to
extract the key bytes on access.
This change also allows the removal of the
simple_asn1dependency.Closes #337 after #483 is merged.