Skip to content

Make options a DTO, add types in all the spots. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChadSikorra merged 3 commits into from
Apr 26, 2026

Add some tests.

1ec3648
Select commit
Loading
Failed to load commit list.
Merged

Make options a DTO, add types in all the spots. #10

Add some tests.
1ec3648
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 26, 2026 in 0s

83.29% (+2.10%) compared to 58b314e

View this Pull Request on Codecov

83.29% (+2.10%) compared to 58b314e

Details

Codecov Report

❌ Patch coverage is 86.14232% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (58b314e) to head (1ec3648).

Files with missing lines Patch % Lines
src/FreeDSx/Socket/HasSocketOptions.php 85.00% 15 Missing ⚠️
src/FreeDSx/Socket/Socket.php 83.33% 10 Missing ⚠️
src/FreeDSx/Socket/SocketServer.php 90.56% 5 Missing ⚠️
src/FreeDSx/Socket/SocketPool.php 62.50% 3 Missing ⚠️
src/FreeDSx/Socket/SocketPoolOptions.php 75.00% 3 Missing ⚠️
src/FreeDSx/Socket/Queue/Asn1MessageQueue.php 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main      #10      +/-   ##
============================================
+ Coverage     81.19%   83.29%   +2.10%     
- Complexity      101      142      +41     
============================================
  Files             7       10       +3     
  Lines           319      425     +106     
============================================
+ Hits            259      354      +95     
- Misses           60       71      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov