Skip to content

Make options a DTO, add types in all the spots.#10

Merged
ChadSikorra merged 3 commits intomainfrom
upgrade/php
Apr 26, 2026
Merged

Make options a DTO, add types in all the spots.#10
ChadSikorra merged 3 commits intomainfrom
upgrade/php

Conversation

@ChadSikorra
Copy link
Copy Markdown
Contributor

@ChadSikorra ChadSikorra commented Apr 26, 2026

Now that PHP 8.2 is the min version and I'm preparing to align this with the LDAP 1.0 release, I'm making some breaking changes that the new LDAP 1.0 will work with:

  1. Options class here is now a DTO. Will be glad to get rid of this array based config.
  2. Adding actual types everywhere possible.
  3. strict types enforced.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 26, 2026

Codecov Report

❌ Patch coverage is 86.14232% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (58b314e) to head (1ec3648).

Files with missing lines Patch % Lines
src/FreeDSx/Socket/HasSocketOptions.php 85.00% 15 Missing ⚠️
src/FreeDSx/Socket/Socket.php 83.33% 10 Missing ⚠️
src/FreeDSx/Socket/SocketServer.php 90.56% 5 Missing ⚠️
src/FreeDSx/Socket/SocketPool.php 62.50% 3 Missing ⚠️
src/FreeDSx/Socket/SocketPoolOptions.php 75.00% 3 Missing ⚠️
src/FreeDSx/Socket/Queue/Asn1MessageQueue.php 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #10      +/-   ##
============================================
+ Coverage     81.19%   83.29%   +2.10%     
- Complexity      101      142      +41     
============================================
  Files             7       10       +3     
  Lines           319      425     +106     
============================================
+ Hits            259      354      +95     
- Misses           60       71      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChadSikorra ChadSikorra merged commit 7f4cb90 into main Apr 26, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant