✨ Add per-server SMB encryption option#1564
Open
Victor-root wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed ✨
This adds a new per-server SMB encryption option for SMB connections.
By default, nothing changes:
When enabled, the app uses SMBJ with
SmbConfig.builder().withEncryptData(true).build(), which allows connecting to SMB3 servers or shares that require encryption.Why 🔐
This is related to:
server signing&server smb encrypt#486#1271 already proposed enabling SMB encryption support globally, but this PR takes a more conservative approach: SMB encryption is now controlled per server instead of being enabled for every SMB connection.
This should help with servers such as:
Testing ✅
I tested this myself in real conditions on Android with a server requiring SMB encryption.
I also verified that the option is saved per server and that the default behavior remains unchanged when the option is disabled.
Translations 🌍
I added translations for all currently available app languages.