Skip to content

✨ Add per-server SMB encryption option#1564

Open
Victor-root wants to merge 3 commits into
zhanghai:masterfrom
Victor-root:feature/smb-encrypt
Open

✨ Add per-server SMB encryption option#1564
Victor-root wants to merge 3 commits into
zhanghai:masterfrom
Victor-root:feature/smb-encrypt

Conversation

@Victor-root

Copy link
Copy Markdown

What changed ✨

This adds a new per-server SMB encryption option for SMB connections.

By default, nothing changes:

  • existing SMB servers keep the current behavior
  • new SMB servers use the current non-encrypted SMBJ configuration unless the option is enabled

When enabled, the app uses SMBJ with SmbConfig.builder().withEncryptData(true).build(), which allows connecting to SMB3 servers or shares that require encryption.

Why 🔐

This is related to:

#1271 already proposed enabling SMB encryption support globally, but this PR takes a more conservative approach: SMB encryption is now controlled per server instead of being enabled for every SMB connection.

This should help with servers such as:

  • Samba shares with mandatory SMB encryption
  • Windows shares requiring SMB encryption
  • NAS devices enforcing encrypted SMB3 sessions

Testing ✅

I tested this myself in real conditions on Android with a server requiring SMB encryption.

I also verified that the option is saved per server and that the default behavior remains unchanged when the option is disabled.

Translations 🌍

I added translations for all currently available app languages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant