duc.c: Create ~/.cache if needed

[licy183]

If ~/.cache doesn't exist, some error will happen. See termux/termux-packages#11350 (comment).

[l8gravely]

I'd merge this, but you need to handle errors better. If the mkdir() call fails, duc needs to error our more gracefully. I like the idea, but it needs some more work.

And apologies for the delay, now that v1.5.0-rc1 is about to come out, it would be great if you could re-spin this to address these issues.

[jmtd]

Erm, 5da92b8 causes duc to fatally exit if the mkdir fails, which occurs if the directory already exists...

[l8gravely]

Exactly! You need to check if the directory exists, or run mkdir() and check the return properly. I've already pushed a possible fix for this, but my brain is mush tonight and I still need to test stuff better.

[jmtd]

I raised PR #356 to fix this a couple of weeks ago. Edit: oh no I didn't, I only fixed the related issue of failing if ~/.cache/duc already exists.

[l8gravely]

>>>> "Jonathan" == Jonathan Dowland ***@***.***> writes: #jmtd left a comment (zevv/duc#296) I raised PR #356 to fix this a couple of weeks ago

And I looked at it and I had some comments on how it was done.

[jmtd]

And I looked at it and I had some comments on how it was done.

thanks! I missed wherever those comments are, because they aren’t on the PR.