Fixing permissions for the daemon directory#2598
Open
dimitriy-dade wants to merge 2 commits into
Open
Conversation
dimitriy-dade
requested review from
adamierymenko,
countbinoculars,
cspiegel and
joseph-henry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced regression bug when releasing 1.16.2. Went from old legacy MsiLockPermComponent to new MsiLockPermissionsExComponent, which by default uses parent dir (C:\ProgramData) permissions. This applies correct permissions to C:\ProgramData\ZeroTier\One dir.
Includes changes to .aip file, but also forcing proper permissions by the code. The reason is .aip file only forces permissions for the virgin install. If the directory already exists we need to enforce it in source code.