Skip to content

docs: Fix routing sample#26

Open
TsuyoshiUshio wants to merge 1 commit intoyvele:masterfrom
TsuyoshiUshio:fixreadme
Open

docs: Fix routing sample#26
TsuyoshiUshio wants to merge 1 commit intoyvele:masterfrom
TsuyoshiUshio:fixreadme

Conversation

@TsuyoshiUshio
Copy link
Copy Markdown

In my environment, the basic sample doesn't work. This solution works. However, I'm not sure what do you intent. Feel free to close this if I made a mistake.

The routing sample doesn't  work.   This solution works. however I'm not sure your intent. 
Feel free to reject if it is not good.
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 29, 2018

Codecov Report

Merging #26 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines          67     67           
  Branches       18     18           
=====================================
  Hits           67     67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bd9041...f5cf9a5. Read the comment docs.

Copy link
Copy Markdown
Owner

@yvele yvele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add the unnecessary hello part

Comment thread README.md
// Create express app as usual
const app = express();
app.get("/api/:foo/:bar", (req, res) => {
app.get("/api/hello/:foo/:bar", (req, res) => {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding hello?

Comment thread README.md
"direction" : "in",
"name" : "req",
"route" : "foo/{bar}/{id}"
"route" : "hello/{foo}/{bar}"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean {foo}/{bar}?

@yvele yvele changed the title fix routing sample docs: Fix routing sample Feb 13, 2019
@yvele yvele self-assigned this Feb 13, 2019
@yvele yvele assigned TsuyoshiUshio and unassigned yvele May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants