Skip to content

refactor: inline to html! callsite#4145

Open
Madoshakalaka wants to merge 2 commits intomasterfrom
refactor-examples
Open

refactor: inline to html! callsite#4145
Madoshakalaka wants to merge 2 commits intomasterfrom
refactor-examples

Conversation

@Madoshakalaka
Copy link
Copy Markdown
Member

@Madoshakalaka Madoshakalaka commented Apr 26, 2026

Description

eliminated a bunch of functions that return Html and were only used once in some html! callsite

Fixes #4144

Checklist

  • I have reviewed my own code

@Madoshakalaka Madoshakalaka added the A-examples Area: The examples label Apr 26, 2026
github-actions[bot]
github-actions Bot previously approved these changes Apr 26, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
actix_ssr_router 613.698 613.862 +0.164 +0.027%
async_clock 100.490 100.490 0 0.000%
axum_ssr_router 613.690 613.854 +0.164 +0.027%
boids 164.206 164.252 +0.046 +0.028%
communication_child_to_parent 93.912 93.912 0 0.000%
communication_grandchild_with_grandparent 105.908 105.908 0 0.000%
communication_grandparent_to_grandchild 102.263 102.263 0 0.000%
communication_parent_to_child 91.338 91.338 0 0.000%
contexts 106.138 106.138 0 0.000%
counter 86.171 86.171 0 0.000%
counter_functional 88.190 88.190 0 0.000%
dyn_create_destroy_apps 90.059 90.059 0 0.000%
file_upload 99.687 99.779 +0.093 +0.093%
function_delayed_input 94.802 94.802 0 0.000%
function_memory_game 169.972 169.972 0 0.000%
function_router 399.553 399.963 +0.410 +0.103%
function_todomvc 164.688 164.688 0 0.000%
futures 235.143 235.143 0 0.000%
game_of_life 100.915 100.949 +0.034 +0.034%
immutable 258.956 258.956 0 0.000%
inner_html 81.015 81.015 0 0.000%
js_callback 110.030 110.030 0 0.000%
keyed_list 176.376 176.356 -0.020 -0.011%
mount_point 84.384 84.384 0 0.000%
nested_list 113.212 113.134 -0.078 -0.069%
node_refs 91.905 91.905 0 0.000%
password_strength 1717.884 1717.884 0 0.000%
portals 93.554 93.554 0 0.000%
router 366.253 366.045 -0.208 -0.057%
suspense 113.876 113.876 0 0.000%
timer 88.756 88.756 0 0.000%
timer_functional 99.215 99.217 +0.002 +0.002%
todomvc 141.766 141.686 -0.080 -0.056%
two_apps 86.373 86.373 0 0.000%
web_worker_fib 136.689 136.689 0 0.000%
web_worker_prime 185.081 185.081 0 0.000%
webgl 83.158 83.158 0 0.000%

✅ None of the examples has changed their size significantly.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 26, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 310.814 311.416 311.099 0.192
Hello World 10 504.983 522.646 507.168 5.448
Function Router 10 32686.994 33247.167 32977.006 183.236
Concurrent Task 10 1005.538 1007.133 1006.372 0.654
Many Providers 10 1073.148 1114.798 1104.806 12.263

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 291.406 291.690 291.559 0.113
Hello World 10 482.414 484.683 482.989 0.697
Function Router 10 30790.218 31149.718 30968.201 114.317
Concurrent Task 10 1005.950 1006.748 1006.393 0.308
Many Providers 10 1030.667 1053.616 1045.199 6.245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-examples Area: The examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modernize example code with preamble statements

1 participant