Open
Conversation
vagos
force-pushed
the
main
branch
2 times, most recently
from
f3e379d to
8878890
Compare
okuryu
reviewed
Nov 16, 2024
Comment on lines
+87
to
+89
| if (typeof value === 'number' && isNaN(value)) { | ||
| return '@__N-' + UID + '-' + (nans.push(value) - 1) + '__@'; | ||
| } |
Collaborator
There was a problem hiding this comment.
it might be better to combine this if statement with the number if statement.
Lines 132 to 134 in 5838b91
Signed-off-by: Evangelos Lamprou <vagos@lamprou.xyz>
Pet3cy
approved these changes
Sep 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.