When printing GOLDEN/OUTPUT print the first mismatch in red.#61
Open
xross wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the debug output of ComparisonTester.run() so that when verbose printing is enabled, the first detected mismatch between the golden (expected) output and the actual output is visually emphasized in red to make failures faster to spot.
Changes:
- Tracks the first mismatch across the comparison run and highlights it in red.
- Consolidates mismatch detection into a
line_mismatchflag to drive both failure recording and printing. - Adjusts ordered/unordered comparison flow to avoid attempting content comparisons once a length-based mismatch is already known for that line.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
humphrey-xmos
approved these changes
Jun 11, 2026
|
|
||
| highlight_line = line_mismatch and not highlighted_first_mismatch | ||
| if highlight_line: | ||
| highlighted_first_mismatch = True |
There was a problem hiding this comment.
Slightly confusing that "first-mismatch" is set to True, when it disables the highlighting?
Maybe swap True/False?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.