float 32 to s32 conversion optimisation#243
Open
henkmuller wants to merge 2 commits into
Open
Conversation
uvvpavel
requested changes
Jun 11, 2026
uvvpavel
left a comment
uvvpavel
left a comment
Contributor
There was a problem hiding this comment.
Good opt! I forgot that we've had vector apis for those conversions and only optimised the scalar ones.
There are few comments, mostly around the code style
Contributor
There was a problem hiding this comment.
Now that xm.entsp is gone, I would remove NSTACKWORDS altogether, so it's not modifiable anymore
Contributor
There was a problem hiding this comment.
I see you removed s4, but s5 is still used, and both of them are saved to stack. Could you use s4 instead of s5 and only save s4 to stack? This is not gonna give us any cycles but will be a bit cleaner
| #define tmp1 s2 | ||
| #define tmp0 s3 | ||
|
|
||
| #define _0 x28 |
Contributor
There was a problem hiding this comment.
Could you change it to t3 as it's more idiomatic, please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assembly optimisation using VX4 features.
Provides 1.5 x round-trip speedup, useful for floating point FFTs
Notifying @andrewxcav, @alexyiuxmos