Skip to content

Enable @ and / completion when reading queued prompts#565

Open
Gleek wants to merge 2 commits into
xenodium:mainfrom
Gleek:main
Open

Enable @ and / completion when reading queued prompts#565
Gleek wants to merge 2 commits into
xenodium:mainfrom
Gleek:main

Conversation

@Gleek
Copy link
Copy Markdown
Contributor

@Gleek Gleek commented May 2, 2026

Closes #556.

  • What changed: agent-shell-queue-request now offers @ (project files) and / (slash commands) completion in the queued-prompt minibuffer, mirroring the regular shell input.
  • A buffer-local override agent-shell-completion--shell-buffer lets the existing CAPFs source data from a designated shell. New helpers agent-shell-completion--setup-minibuffer / --cleanup-minibuffer install/remove the hooks via minibuffer-with-setup-hook + minibuffer-exit-hook.

Checklist

  • I agree to communicate (PR description and comments) with the author myself (not AI-generated).
  • I've reviewed all code in PR myself and will vouch for its quality.
  • I've read and followed the Contributing guidelines.
  • I've filed a feature request/discussion for a new feature.
  • I'm making visual changes, so I'm including screenshots so you can view and discuss. (in the issue linked)
  • I've added tests where applicable.
  • I've updated documentation where necessary.
  • I've run M-x checkdoc and M-x byte-compile-file.

Gleek added 2 commits May 12, 2026 09:53
Each streaming chunk delete-and-reinserts the in-progress block, which
displaces any markers inside that region to its start. `(point-marker)`
in the viewport branch and `save-mark-and-excursion`/`save-excursion`
(in `agent-shell-ui-update-fragment` and `shell-maker-with-auto-scroll-edit`)
all rely on markers, so cursor and viewport jumped to the block header
when reading mid-stream.

Switch to integer-based save/restore for point and window-start: inside
`agent-shell-ui-update-fragment` (covers the viewport flow) and around
`shell-maker-with-auto-scroll-edit` in the main shell branch (overrides
shell-maker's broken `save-excursion`).
liaowang11 added a commit to liaowang11/agent-shell that referenced this pull request May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: Enable @// completion when reading queued prompts

1 participant