Merged
Conversation
olix3001
approved these changes
Feb 24, 2026
Contributor
olix3001
left a comment
olix3001
left a comment
There was a problem hiding this comment.
If it works it works, but I think it might be better to be consistant
| # Install pnpm | ||
| RUN corepack enable && corepack prepare pnpm@10.30.1 --activate | ||
| # Install pnpm and husky | ||
| RUN corepack enable && corepack prepare pnpm@10.30.1 --activate && npm install -g husky |
Contributor
There was a problem hiding this comment.
Shouldn't we use pnpm?
Suggested change
| RUN corepack enable && corepack prepare pnpm@10.30.1 --activate && npm install -g husky | |
| RUN corepack enable && corepack prepare pnpm@10.30.1 --activate && pnpm install -g husky |
| WORKDIR /app | ||
| ADD package.json pnpm-lock.yaml ./ | ||
| RUN pnpm install --frozen-lockfile | ||
| RUN pnpm install --frozen-lockfile && npx husky install |
Contributor
There was a problem hiding this comment.
Same here
Suggested change
| RUN pnpm install --frozen-lockfile && npx husky install | |
| RUN pnpm install --frozen-lockfile && pnpx husky install |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.