Implement test suite for teams and invitations#46
Merged
Conversation
Closed
InfoX1337
requested changes
Feb 24, 2026
Contributor
InfoX1337
left a comment
InfoX1337
left a comment
There was a problem hiding this comment.
Comments about tests that should (or could) be implemented :)
Contributor
There was a problem hiding this comment.
Add the following tests
- Cannot invite a user who is already a team member
- Cannot invite a user with an invalid email format
- Cannot accept an expired invitation
- Cannot reject an expired invitation
- Cannot invite a user to a non-existent team
- Cannot list invitations for a non-existent team
- Cannot accept an invitation if the team is deleted?
- Cannot invite a user if the team has reached its member limit
Contributor
There was a problem hiding this comment.
Add the following tests
- Cannot create a team with a duplicate name within the same event? I dont think thats allowed.
- Cannot update a team to have a duplicate name within the same event? as above.
- Cannot delete a team that has ongoing tasks or dependencies?
- Cannot list teams for an event that the user is not a part of
- Cannot create a team for an event that is in draft mode. - User shouldn't be able to see it, but testing it seems smart.
- Fails to update a team with invalid data (e.g. empty name), or the endpoint ignores the invalid data.
# Conflicts: # .env.example
…ving/kicking feature
olix3001
force-pushed
the
36-testing-teams-and-invitations
branch
from
006046c to
e2b3c13
Compare
InfoX1337
approved these changes
Feb 24, 2026
Contributor
InfoX1337
left a comment
InfoX1337
left a comment
There was a problem hiding this comment.
One comment, apart from that lgtm.
app/controllers/teams_controller.ts
Outdated
| } | ||
|
|
||
| // Kick team member by member uuid | ||
| async kickMember({ auth, bouncer, request, response }: HttpContext) { |
Contributor
There was a problem hiding this comment.
With this new function is there a possibility that the only team member leaves? If so how is it handled?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement full test suite for endpoints related to teams and invitations.
Closes #36
Closes #37