Open
Conversation
This was referenced May 5, 2021
Open
Collaborator
Author
|
Since this repo uses Circle CI for WP.org deploys, I've removed those two GH Actions from this PR and limited the PR to the Linting action. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds in GitHub Actions to help with automation relating to:
This will require adding GitHub repository secrets for
SVN_USERNAMEandSVN_PASSWORDfor an account that has commit access for the plugin on WordPress.org SVN. I recommend having a company/org account, essentially one NOT linked to a specific person, so that releases/updates can continue without being blocked by a specific person moving off the project.Most notably the PR does NOT add in a testing action given how complex the existing CircleCI integration is. However getting that test process ported into the sample test action linked just previously would even further reduce tooling dependencies to just GitHub.
I'd similarly recommend a new
developbranch offmasterthat's set as the default branch for the repo and that future releases essentially merges develop into master (more on that here). Further, I'd recommend to use the GitHub branch renaming to renamemasterto something liketrunkormainto avoid using the "master" term. I'm happy to help scan the repo for places that need branch references updated, just let me know!Alternate Designs
Continue to run linting and handle WordPress.org SVN updates elsewhere.
Benefits
Further automates what can be heavily manual processes, also standardizes all checking/testing/linting to within GitHub to help reduce tooling.
Possible Drawbacks
None identified.
Verification Process
Manually verified via VS Code and GitHub Desktop UI.
Checklist:
Applicable Issues
none identified
Changelog Entry