fix: use simple v-prefixed tags and fix gem publish path#440
Closed
gjtorikian wants to merge 1 commit intomainfrom
Closed
fix: use simple v-prefixed tags and fix gem publish path#440gjtorikian wants to merge 1 commit intomainfrom
gjtorikian wants to merge 1 commit intomainfrom
Conversation
Release Please was creating tags like `workos/v6.1.0` instead of `v6.1.0` because `include-component-in-tag` defaults to true. This caused the publish workflow to look for `pkg/workos-workos/v6.1.0.gem` instead of `pkg/workos-6.1.0.gem`. - Set `include-component-in-tag: false` in release-please-config.json - Update VERSION extraction in release.yml to handle both tag formats Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Greptile OverviewGreptile SummaryThis PR attempts to fix the v6.1.0 release failure by configuring release-please to generate simple Key changes:
Critical issue found:
This will cause the next release to fail because Confidence Score: 0/5
Important Files Changed
|
| - name: Publish to RubyGems | ||
| run: | | ||
| VERSION="${GITHUB_REF_NAME#v}" | ||
| VERSION="${GITHUB_REF_NAME##*/v}" |
There was a problem hiding this comment.
The pattern ##*/v won't strip the v from simple tags like v6.1.0 - it will output v6.1.0 instead of 6.1.0. This causes gem push to look for pkg/workos-v6.1.0.gem which won't exist.
Suggested change
| VERSION="${GITHUB_REF_NAME##*/v}" | |
| VERSION="${GITHUB_REF_NAME##*/}" | |
| VERSION="${VERSION#v}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include-component-in-tag: falseinrelease-please-config.jsonso future tags arev6.1.0instead ofworkos/v6.1.0release.ymlto handle both tag formats as a safety netContext
The v6.1.0 release (publish run) failed because:
workos/v6.1.0(component-prefixed)VERSIONvia${GITHUB_REF_NAME#v}→workos/v6.1.0(no leadingvto strip)gem pushlooked forpkg/workos-workos/v6.1.0.gemwhich doesn't existTest plan
v6.1.0🤖 Generated with Claude Code