Preserve verification_prefix in organisation domain deserialisation#1486
Open
smorimoto wants to merge 1 commit intoworkos:mainfrom
Open
Preserve verification_prefix in organisation domain deserialisation#1486smorimoto wants to merge 1 commit intoworkos:mainfrom
smorimoto wants to merge 1 commit intoworkos:mainfrom
Conversation
Contributor
Greptile OverviewGreptile SummaryAdds the missing Changes made:
The implementation is consistent with existing patterns (matches Confidence Score: 5/5
Important Files Changed
Last reviewed commit: f986675 |
The OrganizationDomain interface and deserialiser were missing the verification_prefix field, which is present in the Events API response for organization_domain.* events and in nested domain data within organization.* events. Adds verification_prefix as an optional field to both OrganizationDomain and OrganizationDomainResponse, and maps it in deserializeOrganizationDomain.
f986675 to
378ded6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verification_prefixas an optional field toOrganizationDomainandOrganizationDomainResponseinterfacesverification_prefix→verificationPrefixindeserializeOrganizationDomainThe Events API documentation for
organization_domain.*events includes averification_prefixfield in the event data, but the deserialiser was silently dropping it.Test plan
npx tsc --noEmit)npm test)