Skip to content

Preserve verification_prefix in organisation domain deserialisation#1486

Open
smorimoto wants to merge 1 commit intoworkos:mainfrom
smorimoto:fix-organization-domain-verification-prefix
Open

Preserve verification_prefix in organisation domain deserialisation#1486
smorimoto wants to merge 1 commit intoworkos:mainfrom
smorimoto:fix-organization-domain-verification-prefix

Conversation

@smorimoto
Copy link
Contributor

Summary

  • Adds verification_prefix as an optional field to OrganizationDomain and OrganizationDomainResponse interfaces
  • Maps verification_prefixverificationPrefix in deserializeOrganizationDomain

The Events API documentation for organization_domain.* events includes a verification_prefix field in the event data, but the deserialiser was silently dropping it.

Test plan

  • TypeScript type check passes (npx tsc --noEmit)
  • All existing tests pass (npm test)
  • Linter and formatter pass

@smorimoto smorimoto requested a review from a team as a code owner February 13, 2026 18:00
@smorimoto smorimoto requested a review from imkesin February 13, 2026 18:00
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

Adds the missing verificationPrefix field to OrganizationDomain interfaces and deserializer. The field was documented in the Events API for organization_domain.* events but was being silently dropped during deserialization.

Changes made:

  • Added optional verificationPrefix field to OrganizationDomain interface
  • Added optional verification_prefix field to OrganizationDomainResponse interface
  • Updated deserializeOrganizationDomain to map verification_prefixverificationPrefix

The implementation is consistent with existing patterns (matches verificationToken field structure) and correctly handles the snake_case to camelCase transformation.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • The changes are minimal, focused, and follow existing patterns perfectly. The field is correctly typed as optional, properly positioned in the interfaces, and the deserializer mapping is consistent with all other field mappings. No behavioral changes, no breaking changes, and no security concerns.
  • No files require special attention

Important Files Changed

Filename Overview
src/organization-domains/interfaces/organization-domain.interface.ts Added optional verificationPrefix field to both interfaces, correctly typed and positioned
src/organization-domains/serializers/organization-domain.serializer.ts Added mapping for verification_prefix to verificationPrefix, matching the existing pattern

Last reviewed commit: f986675

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

The OrganizationDomain interface and deserialiser were missing the
verification_prefix field, which is present in the Events API response
for organization_domain.* events and in nested domain data within
organization.* events.

Adds verification_prefix as an optional field to both
OrganizationDomain and OrganizationDomainResponse, and maps it in
deserializeOrganizationDomain.
@smorimoto smorimoto force-pushed the fix-organization-domain-verification-prefix branch from f986675 to 378ded6 Compare February 13, 2026 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant