Library: Port 'Text Colors' to Python#735
Conversation
|
Very sorry about the CI issues, that was another demo that caused this. Will be fixed by #736, you may want to update your branches after this. |
|
I don't get what I should do - should I rebase on top of "main" or get "main" and use it to reformat it? |
UrtsiSantsi
force-pushed
the
python_text_colors
branch
from
fe69c55 to
3c9e805
Compare
|
Fixed |
| import gi | ||
|
|
||
| gi.require_version("Gtk", "4.0") | ||
| gi.require_version("Pango", "1.0") |
There was a problem hiding this comment.
Specifying the version for Pango is not necessary, there is only one version.
There was a problem hiding this comment.
Only one so far 😄 - there is a pango2 pull request by Matthias Clasen. Is this a problem in reality, specifying a version even if there is only one or just a personal preference?
There was a problem hiding this comment.
And what about Glib and Gio?
There was a problem hiding this comment.
Oh sorry, I wasn't aware Pango 2 was a thing. In that case we should keep this 👍
In general my comment here: #732 (comment)
There was a problem hiding this comment.
See also #738 - I'll think about / do some research if specifying the Pango version makes sense, but in doubt we keep it.
theCapypara
left a comment
theCapypara
left a comment
There was a problem hiding this comment.
LGTM! There were a few minor code styling issues, I added a commit for those.
There was also a debug print still in there, removed that as well.
Co-authored-by: Marco Capypara Köpcke <hello@capypara.de>
2 participants
No description provided.