Fix buffer-overflow in LMS leaf cache indexing#9919
Open
anhu wants to merge 1 commit intowolfSSL:masterfrom
Open
Fix buffer-overflow in LMS leaf cache indexing#9919anhu wants to merge 1 commit intowolfSSL:masterfrom
anhu wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Member
Author
|
No ZD, No issue. Found while making a wolfboot demo. |
wc_lms_treehash_init() writes leaf node hashes into the leaf cache
using an absolute index (i * hash_len), but the cache is only
max_cb entries starting from leaf->idx. When leaf->idx > 0 (which
occurs when wc_LmsKey_Reload is called after signing more than
max_cb times), the write goes past the end of the cache buffer.
Fix by using the relative offset (i - leaf->idx) * hash_len instead.
Added unit tests (test_lms.c):
- test_wc_LmsKey_sign_verify: basic sign/verify sanity check
- test_wc_LmsKey_reload_cache: (TDD) reproduces the overflow by
signing 33 times then reloading the key
Member
Author
|
Jenkins retest this please. |
Member
Author
|
jenkins retest this please. |
Member
Author
|
jenkins retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wc_lms_treehash_init() writes leaf node hashes into the leaf cache using an absolute index (i * hash_len), but the cache is only max_cb entries starting from leaf->idx. When leaf->idx > 0 (which occurs when wc_LmsKey_Reload is called after signing more than max_cb times), the write goes past the end of the cache buffer.
Fix by using the relative offset (i - leaf->idx) * hash_len instead.
Added unit tests (test_lms.c):