Skip to content

Add hitch 1.8.0 support.#325

Open
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl:hitch_1.8.0
Open

Add hitch 1.8.0 support.#325
kareem-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
kareem-wolfssl:hitch_1.8.0

Conversation

@kareem-wolfssl
Copy link
Contributor

@kareem-wolfssl kareem-wolfssl commented Mar 5, 2026

Update hitch support for 1.8.0.
wolfSSL has added all of the OCSP functions hitch is using, so no need to patch the OCSP functions anymore.
Requires wolfSSL/wolfssl#9897.

@kareem-wolfssl kareem-wolfssl self-assigned this Mar 5, 2026
kareem-wolfssl added a commit to kareem-wolfssl/wolfssl that referenced this pull request Mar 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Hitch 1.8.0 patch support for building against wolfSSL, removing the need for OCSP function patching by introducing a --with-wolfssl configure path.

Changes:

  • Adds --with-wolfssl option and wolfSSL/OpenSSL conditional configuration in configure.ac.
  • Disables OpenSSL ENGINE initialization when building with wolfSSL.
  • Updates certificate TLV buffer type to BUF_MEM.
Comments suppressed due to low confidence (2)

hitch/hitch_1.8.0.patch:1

  • The AC_ARG_WITH([wolfssl], ...) handler never assigns with_wolfssl when the option is provided, so with_wolfssl can be empty and still satisfy test \"$with_wolfssl\" != no. This also mis-handles --with-wolfssl=no (it will set wolfssl_path=no and still enter the wolfSSL branch). Assign with_wolfssl=$withval in the option handler (and normalize no|yes|<path>), then key the conditional off the normalized value.
commit 7afa1dc73a768423ec5d3823e62a58c6d0bd4aeb

hitch/hitch_1.8.0.patch:1

  • The wolfSSL branch unconditionally defines feature macros (including HAVE_TLS_1_3) without any configure-time verification. This can silently misconfigure builds if wolfSSL is compiled without certain features/APIs. Prefer using HITCH_CHECK_FUNC/AC_CHECK_FUNCS (or a version/feature check via pkg-config --modversion wolfssl) to conditionally define these macros based on actual availability.
commit 7afa1dc73a768423ec5d3823e62a58c6d0bd4aeb

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants